[LLDB][MIPS] Added expected failure for "test disassembler settings"

[nitesh.jain]

Summary

The test case "test disassembler settings" is specific to x86 and it will failed for MIPS Architecture. Hence it is marked as a expected failure for MIPS.

[emaste]

I wonder if this shouldn't be a (newly added) @skipUnlessx86 instead?

[clayborg]

I would rather see this as an opt in based on one or more architectures:

@skipUnlessArch(['x86-64', 'i386'])

That way we don't have to keep adding new architectures to avoid.

[nitesh.jain]

Added skipUnlessArch which will be used to run Architecture specific test case.

[clayborg]

Ahh.. much better.

lldb/trunk/test/lldbtest.py

 def expectedFailureIcc(bugnumber=None):
     return expectedFailureCompiler('icc', None, bugnumber)
 
 def expectedFailureArch(arch, bugnumber=None):
     def fn(self):
         return arch in self.getArchitecture()
     return expectedFailure(fn, bugnumber)
 
+def skipUnlessArch(arch):
+    def fn(self):
+        return not self.getArchitecture() in arch 
+    return expectedFailure(fn, None)
+
 def expectedFailurei386(bugnumber=None):
     return expectedFailureArch('i386', bugnumber)
 
 def expectedFailurex86_64(bugnumber=None):
     return expectedFailureArch('x86_64', bugnumber)
 
 def expectedFailureOS(oslist, bugnumber=None, compilers=None):
     def fn(self):

lldb/trunk/test/settings/TestSettings.py

def test_set_auto_confirm(self):
         self.expect("breakpoint delete",
             startstr = "All breakpoints removed")
 
         # Restore the original setting of auto-confirm.
         self.runCmd("settings clear auto-confirm")
         self.expect("settings show auto-confirm", SETTING_MSG("auto-confirm"),
             startstr = "auto-confirm (boolean) = false")
 
-    @expectedFailureArch("arm")
-    @expectedFailureArch("aarch64")
+    @skipUnlessArch(['x86-64', 'i386'])
     def test_disassembler_settings(self):
         """Test that user options for the disassembler take effect."""
         self.buildDefault()
 
         exe = os.path.join(os.getcwd(), "a.out")
         self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET)
 
         # AT&T syntax