Deprecate `SBValue::TypeIsPointerType`.

[sivachandra]

If this change is OK, you should probably update the Python reference as well: http://lldb.llvm.org/python_reference/lldb.SBValue-class.html

[clayborg]

Looks good.

[chaoren]

Isn't this autogenerated?

// \deprecated { Please use blah instead }

Should work right?

lldb/trunk/include/lldb/API/SBValue.h

#endif
     GetThread();
 
     lldb::SBFrame
     GetFrame();
     
     lldb::SBValue
     Dereference ();
 
+    // Deprecated - please use GetType().IsPointerType() instead.
     bool
     TypeIsPointerType ();
     
     lldb::SBType
     GetType();
     
     lldb::SBValue
     Persist ();

lldb/trunk/source/API/SBValue.cpp

SBValue::Dereference ()
     if (log)
         log->Printf ("SBValue(%p)::Dereference () => SBValue(%p)",
                      static_cast<void*>(value_sp.get()),
                      static_cast<void*>(value_sp.get()));
 
     return sb_value;
 }
 
+// Deprecated - please use GetType().IsPointerType() instead.
 bool
 SBValue::TypeIsPointerType ()
 {
-    bool is_ptr_type = false;
-
-    ValueLocker locker;
-    lldb::ValueObjectSP value_sp(GetSP(locker));
-    if (value_sp)
-        is_ptr_type = value_sp->IsPointerType();
-
-    Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_API));
-    if (log)
-        log->Printf ("SBValue(%p)::TypeIsPointerType () => %i",
-                     static_cast<void*>(value_sp.get()), is_ptr_type);
-
-    return is_ptr_type;
+    return GetType().IsPointerType();
 }
 
 void *
 SBValue::GetOpaqueType()
 {
     ValueLocker locker;
     lldb::ValueObjectSP value_sp(GetSP(locker));
     if (value_sp)