This is an archive of the discontinued LLVM Phabricator instance.

[X86] Remove mergeSPUpdatesUp()
ClosedPublic

Authored by mkuper on Jul 26 2015, 7:06 AM.

Details

Summary

X86FrameLowering has both a mergeSPUpdates() that accepts a direction, and an mergeSPUpdatesUp(), which seem to do the same thing, except for a slightly different interface.
NFC.

Review is mostly for sanity - I don't understand why both functions existed in the first place.

Diff Detail

Repository
rL LLVM

Event Timeline

mkuper updated this revision to Diff 30653.Jul 26 2015, 7:06 AM
mkuper retitled this revision from to [X86] Remove mergeSPUpdatesUp().
mkuper updated this object.
mkuper added reviewers: rnk, majnemer.
mkuper added a subscriber: llvm-commits.
rnk accepted this revision.Jul 27 2015, 11:36 AM
rnk edited edge metadata.

lgtm

Wow, this code duplication dates back to r42870 / 2007. Originally it was split into merge*Up / merge*Down, and then Arnold made a combined version without deleting the specialized variants.

This revision is now accepted and ready to land.Jul 27 2015, 11:36 AM
This revision was automatically updated to reflect the committed changes.