This is an archive of the discontinued LLVM Phabricator instance.

[libunwind] Flip order of extern "C" and attribute(visibility)
ClosedPublic

Authored by rengolin on Jul 24 2015, 8:12 AM.

Reviewers

mclow.lists
t.p.northover

Summary

GCC doesn't seems to like having the attribute before extern, but
Clang accepts it either way. This patch makes it compile on both.

rengolin retitled this revision from to [libunwind] Flip order of extern "C" and attribute(visibility) .

rengolin updated this object.

rengolin set the repository for this revision to rL LLVM.

rengolin added a subscriber: llvm-commits.

Seems fine to me.

Tim.

This revision is now accepted and ready to land.Jul 24 2015, 9:15 AM

r243147. Thanks!

Path

Size

src/

2 lines

	Show First 20 Lines • Show All 991 Lines • ▼ Show 20 Lines
	_Unwind_DeleteException(_Unwind_Exception *exception_object) {			_Unwind_DeleteException(_Unwind_Exception *exception_object) {
	_LIBUNWIND_TRACE_API("_Unwind_DeleteException(ex_obj=%p)\n",			_LIBUNWIND_TRACE_API("_Unwind_DeleteException(ex_obj=%p)\n",
	static_cast<void *>(exception_object));			static_cast<void *>(exception_object));
	if (exception_object->exception_cleanup != NULL)			if (exception_object->exception_cleanup != NULL)
	(*exception_object->exception_cleanup)(_URC_FOREIGN_EXCEPTION_CAUGHT,			(*exception_object->exception_cleanup)(_URC_FOREIGN_EXCEPTION_CAUGHT,
	exception_object);			exception_object);
	}			}

	_LIBUNWIND_EXPORT extern "C" _Unwind_Reason_Code			extern "C" _LIBUNWIND_EXPORT _Unwind_Reason_Code
	__gnu_unwind_frame(_Unwind_Exception *exception_object,			__gnu_unwind_frame(_Unwind_Exception *exception_object,
	struct _Unwind_Context *context) {			struct _Unwind_Context *context) {
	unw_cursor_t cursor = (unw_cursor_t )context;			unw_cursor_t cursor = (unw_cursor_t )context;
	if (unw_step(cursor) != UNW_STEP_SUCCESS)			if (unw_step(cursor) != UNW_STEP_SUCCESS)
	return _URC_FAILURE;			return _URC_FAILURE;
	return _URC_OK;			return _URC_OK;
	}			}

	#endif // _LIBUNWIND_ARM_EHABI			#endif // _LIBUNWIND_ARM_EHABI