This is an archive of the discontinued LLVM Phabricator instance.

Fix Mac OS X build, debugserver version handling.
ClosedPublic

Authored by brucem on Jul 23 2015, 12:18 AM.

Details

Summary

No longer rely on cmake to set DEBUGSERVER_VERSION_STR,
but now generate the _vers.c file like xcode does
and include the generated file into the build on Mac OS X.

This fixes the cmake Mac OS X build after an earlier change
by Jason Molenda.

Diff Detail

Repository
rL LLVM

Event Timeline

brucem updated this revision to Diff 30455.Jul 23 2015, 12:18 AM
brucem retitled this revision from to Fix Mac OS X build, debugserver version handling..
brucem updated this object.
brucem added reviewers: clayborg, jasonmolenda.
brucem added a subscriber: lldb-commits.
brucem added a comment.EditedJul 23 2015, 12:24 AM

Related to this are changes that were made by Todd Fiala last year to not use the version number as it might not be a valid float:

https://github.com/llvm-mirror/lldb/commit/b55b00cb5dac8db75d77868175e2868301ecfd7f

And some changes to support using a pre-processor define by Daniel Malea in 2013:

https://github.com/llvm-mirror/lldb/commit/49dd98a03a868087ce1a292a201618e04cad5e8d

It seems likely that something can be further simplified here.

clayborg accepted this revision.Jul 23 2015, 2:03 PM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Jul 23 2015, 2:03 PM
This revision was automatically updated to reflect the committed changes.