- Add new function getLLDBScriptCommandsFactory, it will launch script file for each step
- Add new builders lldb Windows, and lldb buildserver
- Create triggerable scheduler to trigger android builds
- Add new builders to rotation email monitor list
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
zorg/buildbot/builders/LLDBBuilder.py | ||
---|---|---|
923 ↗ | (On Diff #30441) | Is this for both Linux/OS X and Windows? On Linux/OS X, *.sh might be more appropriate. You can add another argument called 'scriptExtension' or something. |
926 ↗ | (On Diff #30441) | We don't need this until we start testing. Could you move this between build and test? |
943 ↗ | (On Diff #30441) | We can probably condense cleanup, checkout, and configure into one configure script. I don't think the first two steps would be useful to see separately. |
zorg/buildbot/builders/LLDBBuilder.py | ||
---|---|---|
923 ↗ | (On Diff #30441) | Yes, this factory should work for all host platforms. |
926 ↗ | (On Diff #30441) | I was thinking if this revision of binaries doesn't exist, then the build will terminate from here. |
943 ↗ | (On Diff #30441) | We had some build failures with source checkout due to SVN server issue. |
zorg/buildbot/builders/LLDBBuilder.py | ||
---|---|---|
926 ↗ | (On Diff #30441) | Yes, when user click Force Build, it should fetch most recent revision. |
zorg/buildbot/builders/LLDBBuilder.py | ||
---|---|---|
926 ↗ | (On Diff #30441) | The Force Build button seems useless then, unless you add some sort of circular trigger. It doesn't make sense for the bot to just fail either. Can you disable the button just for these bots? |
Address code review feedback
- Combine clewqanup step with source checkout
- Move download binary step after local build
- Use different extension based on host platform
- Add new argument to indicate whether download binary or not
- Remove triggerBuild argument as it always has the same value with bulidAndroid
zorg/buildbot/builders/LLDBBuilder.py | ||
---|---|---|
926 ↗ | (On Diff #30593) | Had offline discussion with Chaoren, Force Build will take the latest available lldb-server binaries for android. It will be handled in downloadBinary script. |