This is an archive of the discontinued LLVM Phabricator instance.

Fix `llvm-config` to emit the linker flag for the combined shared object built by autoconfig/make instead of the individual components.
ClosedPublic

Authored by DiamondLovesYou on Jul 21 2015, 10:33 AM.

Details

Summary

When LLVM is configured to build shared libraries, CMake builds each component as it's own shared object, while autoconfig/make builds them statically and then links them all together to create a single shared object. This change adds compile time config flags to llvm-config so it can know whether LLVM's components are separated or not and act accordingly.

This fixes llvm-config instead of fixing the makefiles to behave like CMake because, AIUI, LLVM's autoconfig/make build system is on the way out anyway.

This change only affects llvm-config from builds that use autoconfig/make.

Diff Detail

Repository
rL LLVM

Event Timeline

DiamondLovesYou retitled this revision from to Fix `llvm-config` to emit the linker flag for the combined shared object built by autoconfig/make instead of the individual components..
DiamondLovesYou updated this object.
DiamondLovesYou added a reviewer: jfb.
DiamondLovesYou set the repository for this revision to rL LLVM.

I almost forgot, the original patch was here.

jfb accepted this revision.Jul 23 2015, 3:03 PM
jfb edited edge metadata.

This lgtm, since it fixes the breakage introduced in the reverted patch.

This revision is now accepted and ready to land.Jul 23 2015, 3:03 PM
This revision was automatically updated to reflect the committed changes.