This is an archive of the discontinued LLVM Phabricator instance.

ELFYAML: Enable parsing of EM_AMDGPU
ClosedPublic

Authored by tstellarAMD on Jul 16 2015, 7:53 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

tstellarAMD retitled this revision from to ELFYAML: Enable parsing of EM_AMDGPU.
tstellarAMD updated this object.
tstellarAMD added a subscriber: llvm-commits.
tstellarAMD edited reviewers, added: silvas; removed: rafael.Jul 22 2015, 3:24 PM
silvas edited edge metadata.Jul 22 2015, 3:59 PM

Not sure it is worth adding the test just to verify that we can type the same thing in two places, but LGTM. If you have the time, it would be nice to split this out into a .def file like we have done in include/llvm/Support/ELFRelocs, so then we can derive both from the same single point of truth.

silvas accepted this revision.Jul 22 2015, 3:59 PM
silvas edited edge metadata.

Forgot to hit "accept".

This revision is now accepted and ready to land.Jul 22 2015, 3:59 PM
This revision was automatically updated to reflect the committed changes.