Page MenuHomePhabricator

Improve conditional opcode handling in emulation based unwinding
ClosedPublic

Authored by tberghammer on Jul 16 2015, 5:33 AM.

Details

Summary

Improve conditional opcode handling in emulation based unwinding

Don't change the CFI information when a conditional instruction is emulated (eg.: popeq {r0, pc}) because the CFI for the next instruction should be the same as the CFI for the current instruction.

Diff Detail

Repository
rL LLVM

Event Timeline

tberghammer retitled this revision from to Improve conditional opcode handling in emulation based unwinding.
tberghammer updated this object.
tberghammer added a reviewer: jasonmolenda.
tberghammer added a subscriber: lldb-commits.
jasonmolenda accepted this revision.Jul 16 2015, 3:06 PM
jasonmolenda edited edge metadata.

looks good to me.

This revision is now accepted and ready to land.Jul 16 2015, 3:06 PM
This revision was automatically updated to reflect the committed changes.