Page MenuHomePhabricator

Remove shell-specific code from TestLoadUnload Makefile.
ClosedPublic

Authored by chaoren on Jul 14 2015, 2:56 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

chaoren retitled this revision from to Remove shell-specific code from TestLoadUnload Makefile..
chaoren updated this object.
chaoren added reviewers: clayborg, sivachandra.
chaoren added a subscriber: lldb-commits.
clayborg requested changes to this revision.Jul 15 2015, 11:05 AM
clayborg edited edge metadata.

Use the $(DS) variable and this will be good go.

test/functionalities/load_unload/Makefile
28 ↗(On Diff #29718)

I believe our base makefile rules have a variable names $(DS) so this should probably be:

DS_IF_DARWIN = $(DS) -o $@.dSYM $@
This revision now requires changes to proceed.Jul 15 2015, 11:05 AM
chaoren edited edge metadata.
  • Use $(DS) variable.
chaoren added inline comments.Jul 15 2015, 11:22 AM
test/functionalities/load_unload/Makefile
28 ↗(On Diff #29803)

I don't think this test loads the base makefile rules.

chaoren edited edge metadata.
  • Added back the $(DS) variable since we don't source the base Makefile.
clayborg accepted this revision.Jul 15 2015, 1:21 PM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Jul 15 2015, 1:21 PM

The eventual and correct fix it to source the main makefile rules and use the DYLIB_* make variables for LIB_A, and make equivalent DYLIB2_*, DYLIB3_*, DYLIB4_* variables which would allow the top level makefile rules to compile up to 4 shared libraries in one makefile and then use those for LIB_B, LIB_C and LIB_D.

This revision was automatically updated to reflect the committed changes.