Compile and run objc tests in TestObjCBuiltinTypes.py as objc instead of c++.

[dawn]

Summary

The tests in TestObjCBuiltinTypes.py were compiled as C++ which didn't properly define the builtin ObjC type 'id' and caused the DWARF to claim the language was C++ instead of ObjC. As a result, when the language in lldb is set to C++ as read from the DWARF, the test would fail. This fix is a prerequisite to recognizing the language from the DWARF and setting the compiler options accordingly.

[clayborg]

Sean wrote most of this test so I will defer to him on this.

[dawn]

Sean, please review? Thanks.

[dawn]

Added more reviewers in the hopes that someone will review this patch. Please?

[spyffe]

This looks like it's actually testing the wrong thing… the point is that the expression parser is in ObjC++ mode at all times and we want to make sure that we aren't misinterpreting something that happens to have the name "id" from C++ as something that's an ObjC id.

I'm concerned about the implicit suggestion that we not be in ObjC++ mode at all times. Specifically, it should be possible to run [NSApplication sharedApplication] wherever I'm stopped in an app. I would only want to turn the ObjC parts completely off if there were no Objective-C at all in the program; is this something we're planning on checking?

BTW, the reverse (no C++ if you're not in C++ mode) is going to be a lot trickier because the expression parser uses reference types internally.

[dawn]

In D11173#208329, @spyffe wrote:

This looks like it's actually testing the wrong thing… the point is that the expression parser is in ObjC++ mode at all times and we want to make sure that we aren't misinterpreting something that happens to have the name "id" from C++ as something that's an ObjC id.

I see.

I'm concerned about the implicit suggestion that we not be in ObjC++ mode at all times.

I ran into this when I wanted to have the default language be that of the selected frame, but folks prefer an option for that, so this test case will still work as is.

Thanks for your review.

test/lang/objc/objc-builtin-types/Makefile

 LEVEL = ../../../make
 
-CXX_SOURCES := main.cpp
+OBJCXX_SOURCES := main.mm
+LD_EXTRAS = -framework Foundation
 
 include $(LEVEL)/Makefile.rules

test/lang/objc/objc-builtin-types/TestObjCBuiltinTypes.py

         # Call super's setUp().
         TestBase.setUp(self)
         # Find the line numbers to break inside main().
-        self.main_source = "main.cpp"
+        self.main_source = "main.mm"
         self.break_line = line_number(self.main_source, '// Set breakpoint here.')
 
     #<rdar://problem/10591460> [regression] Can't print ivar value: error: reference to 'id' is ambiguous

         frame = thread_list[0].GetFrameAtIndex(0)
         self.assertTrue (frame, "Got a valid frame 0 frame.")
 
-        self.expect("expr (foo)", patterns = ["\(ns::id\) \$.* = 0"])
+        self.expect("expr (foo)", patterns = ["\(ns::ns_id\) \$.* = nil"])
 
         self.expect("expr id my_id = 0; my_id", patterns = ["\(id\) \$.* = nil"])
 

test/lang/objc/objc-builtin-types/main.cpp

-namespace ns {
-  typedef int id;
-};
-
-int main()
-{
-  ns::id foo = 0;
-  return foo; // Set breakpoint here.
-}

test/lang/objc/objc-builtin-types/main.mm

 namespace ns {
-  typedef int id;
+  typedef id ns_id;
 };
 
 int main()
 {
-  ns::id foo = 0;
-  return foo; // Set breakpoint here.
+  ns::ns_id foo = 0;
+  return foo == 0 ? 0 : 1; // Set breakpoint here.
 }