This is an archive of the discontinued LLVM Phabricator instance.

Differential D11118

[llgo] update libgo-llgo.so version to match libtool_VERSION
ClosedPublic

Authored by axw on Jul 10 2015, 10:13 PM.

Details

Reviewers
pcc
Commits
rGe5a7b93e1bec: [llgo] update libgo-llgo.so version to match libtool_VERSION
rL242291: [llgo] update libgo-llgo.so version to match libtool_VERSION
Summary

libtool_VERSION was changed in gofrontend a while ago,
but CMakeLists.txt in llgo wasn't updated, and so the
install target fails. Not sure how this went unnoticed
for so long.

Diff Detail

Event Timeline

axw updated this revision to Diff 29510.Jul 10 2015, 10:13 PM
axw retitled this revision from to [llgo] update libgo-llgo.so version to match libtool_VERSION.
axw updated this object.
axw added a reviewer: pcc.
axw added a subscriber: llvm-commits.
pcc accepted this revision.Jul 12 2015, 6:09 PM
pcc edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jul 12 2015, 6:09 PM
axw closed this revision.Jul 15 2015, 6:17 AM

Revision Contents

PathSize
4 lines

Diff 29510

CMakeLists.txt

Show First 20 Lines • Show All 228 Lines • ▼ Show 20 Lines
if(TARGET dfsan) if(TARGET dfsan)
add_libgo_variant("_dfsan" "-fsanitize=dataflow" "-fsanitize=dataflow" dfsan TRUE) add_libgo_variant("_dfsan" "-fsanitize=dataflow" "-fsanitize=dataflow" dfsan TRUE)
endif() endif()
set(LLGO_LIBRARY_DIR ${CMAKE_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}) set(LLGO_LIBRARY_DIR ${CMAKE_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX})
install(FILES ${LLGO_LIBRARY_DIR}/libgo-llgo.a install(FILES ${LLGO_LIBRARY_DIR}/libgo-llgo.a
${LLGO_LIBRARY_DIR}/libgo-llgo.so ${LLGO_LIBRARY_DIR}/libgo-llgo.so
${LLGO_LIBRARY_DIR}/libgo-llgo.so.6 ${LLGO_LIBRARY_DIR}/libgo-llgo.so.7
${LLGO_LIBRARY_DIR}/libgo-llgo.so.6.0.0 ${LLGO_LIBRARY_DIR}/libgo-llgo.so.7.0.0
${LLGO_LIBRARY_DIR}/libgobegin-llgo.a ${LLGO_LIBRARY_DIR}/libgobegin-llgo.a
DESTINATION lib${LLVM_LIBDIR_SUFFIX}) DESTINATION lib${LLVM_LIBDIR_SUFFIX})
install(DIRECTORY ${LLGO_LIBRARY_DIR}/go install(DIRECTORY ${LLGO_LIBRARY_DIR}/go
DESTINATION lib${LLVM_LIBDIR_SUFFIX}) DESTINATION lib${LLVM_LIBDIR_SUFFIX})
add_custom_target(check-libgo add_custom_target(check-libgo
COMMAND make -C ${CMAKE_CURRENT_BINARY_DIR}/libgo -j${PROCESSOR_COUNT} check COMMAND make -C ${CMAKE_CURRENT_BINARY_DIR}/libgo -j${PROCESSOR_COUNT} check
Show All 14 Lines