This is an archive of the discontinued LLVM Phabricator instance.

[DetectDeadLanes] Enable machine verification after this pass
ClosedPublic

Authored by foad on Sep 29 2021, 2:24 AM.

Details

Summary

Machine verification after DetectDeadLanes has been disabled since the
pass was first added in D18427, but I guess this was just due to copy-
and-paste. Enabling it does not show any problems in check-llvm in an
LLVM_ENABLE_EXPENSIVE_CHECKS build.

Diff Detail

Event Timeline

foad created this revision.Sep 29 2021, 2:24 AM
foad requested review of this revision.Sep 29 2021, 2:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2021, 2:24 AM
MatzeB accepted this revision.Oct 1 2021, 9:01 AM

I'm always happy when we can cover more parts of CodeGen with the machine verifier. Let's hope this sticks. LGTM

This revision is now accepted and ready to land.Oct 1 2021, 9:01 AM
This revision was landed with ongoing or failed builds.Oct 1 2021, 10:16 AM
This revision was automatically updated to reflect the committed changes.