This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/SI: Add VI patterns to select FLAT instructions for global memory ops
ClosedPublic

Authored by tstellarAMD on Jul 9 2015, 9:35 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

tstellarAMD retitled this revision from to AMDGPU/SI: Add VI patterns to select FLAT instructions for global memory ops.
tstellarAMD updated this object.
tstellarAMD added a reviewer: arsenm.
tstellarAMD added a subscriber: llvm-commits.
arsenm accepted this revision.Jul 9 2015, 10:05 AM
arsenm edited edge metadata.

LGTM

lib/Target/AMDGPU/SIISelLowering.cpp
271–283 ↗(On Diff #29344)

This should go under all of the cases, since the code assumes MUBUF for all of these address spaces.

271–283 ↗(On Diff #29344)

I'm not sure about using this only for global, but it sort of makes sense

test/CodeGen/AMDGPU/cgp-addressing-modes.ll
7–11 ↗(On Diff #29344)

A test that shows an offset that is sunk on CI and not sunk on VI would be useful. I'm surprised that one of these existing test cases didn't break.

This revision is now accepted and ready to land.Jul 9 2015, 10:05 AM
This revision was automatically updated to reflect the committed changes.