This is an archive of the discontinued LLVM Phabricator instance.

Fix StringExtractor.h issues.
ClosedPublic

Authored by brucem on Jul 7 2015, 8:09 AM.

Details

Summary

Fix StringExtractor.h issues.

  • source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp (#include "Utility/StringExtractor.h): Not needed, this is already included by ProcessKDP.h
  • unittests/Utility/StringExtractorTest.cpp (#include "Utility/StringExtractor.h): Update include path to the new location.

Diff Detail

Repository
rL LLVM

Event Timeline

brucem updated this revision to Diff 29180.Jul 7 2015, 8:09 AM
brucem retitled this revision from to Fix StringExtractor.h issues..
brucem updated this object.
brucem added reviewers: labath, clayborg.
brucem added a subscriber: lldb-commits.
brucem added a comment.Jul 7 2015, 8:10 AM

This doesn't address the issue with debugserver which may be a more controversial fix.

labath accepted this revision.Jul 7 2015, 8:12 AM
labath edited edge metadata.

I'm not absolutely sure if moving the StringExtractor was the right choice on my part, but this does definitely does not make it worse.

This revision is now accepted and ready to land.Jul 7 2015, 8:12 AM
This revision was automatically updated to reflect the committed changes.
clayborg edited edge metadata.Jul 7 2015, 10:03 AM

Seems like StringExtractor.h wasn't actually needed in ProcessKDP.h so it should have been removed from there instead of from the .cpp file.