This is an archive of the discontinued LLVM Phabricator instance.

CodeGen: Test that we do not assign a comdat to available_externally globals.
AbandonedPublic

Authored by pcc on Jul 3 2015, 8:46 PM.

Details

Reviewers
majnemer
Summary

From the linker's perspective, an available_externally global is equivalent to
an external declaration, therefore it should not have a comdat. The presence
of a comdat can cause problems later on during LTO if a comdat containing
an available_externally global is chosen over a comdat containing a real
definition of the global.

Depends on http://reviews.llvm.org/D10941

Diff Detail

Event Timeline

pcc updated this revision to Diff 29044.Jul 3 2015, 8:46 PM
pcc retitled this revision from to CodeGen: Test that we do not assign a comdat to available_externally globals..
pcc updated this object.
pcc added a reviewer: majnemer.
pcc added a subscriber: cfe-commits.

should we ban comdats in available_externally decls in the verifier?

pcc abandoned this revision.Jul 5 2015, 1:42 PM

It is; abandoned.