Fix type signature for CMIUtilString::IsAllValidAlphaAndNumeric. This should take a "const char*" not a "char &".

[brucem]

Summary

Fix type signature for CMIUtilString::IsAllValidAlphaAndNumeric.

This passes the MI tests on Mac OS X.

[ki.stfu]

Looks good apart from one renaming.

tools/lldb-mi/MIUtilString.cpp

478 ↗

(On Diff #28973)

ditto

483 ↗

(On Diff #28973)

ditto

tools/lldb-mi/MIUtilString.h

38 ↗

(On Diff #28973)

In vrText, "r" means reference. Rename it to vpText.

[brucem]

Update per review comments.

Updating D10906: Fix type signature for CMIUtilString::IsAllValidAlphaAndNumeric.

This should take a "const char*" not a "char &".

[ki.stfu]

lgtm

tools/lldb-mi/MIUtilString.cpp

489–491 ↗

(On Diff #28993)

a bit weird. may be the following is better?

for (MIuint i = 0; i < len; ++i)
{
        const MIchar c = vpText[i];
[...]

lldb/trunk/tools/lldb-mi/MICmnLLDBDebugSessionInfo.cpp

CMICmnLLDBDebugSessionInfo::MIResponseFormThreadInfo(const SMICmdData &vCmdData, const lldb::SBThread &vrThread,
     const CMICmnMIValueResult miValueResult1("id", miValueConst1);
     if (!vwrMIValueTuple.Add(miValueResult1))
         return MIstatus::failure;
 
     // Add "target-id"
     const MIchar *pThreadName = rThread.GetName();
     const MIuint len = (pThreadName != nullptr) ? CMIUtilString(pThreadName).length() : 0;
     const bool bHaveName = ((pThreadName != nullptr) && (len > 0) && (len < 32) &&
-                            CMIUtilString::IsAllValidAlphaAndNumeric(*pThreadName)); // 32 is arbitary number
+                            CMIUtilString::IsAllValidAlphaAndNumeric(pThreadName)); // 32 is arbitary number
     const MIchar *pThrdFmt = bHaveName ? "%s" : "Thread %d";
     CMIUtilString strThread;
     if (bHaveName)
         strThread = CMIUtilString::Format(pThrdFmt, pThreadName);
     else
         strThread = CMIUtilString::Format(pThrdFmt, rThread.GetIndexID());
     const CMICmnMIValueConst miValueConst2(strThread);
     const CMICmnMIValueResult miValueResult2("target-id", miValueConst2);

lldb/trunk/tools/lldb-mi/MIUtilString.h

class CMIUtilString : public std::string
   public:
     typedef std::vector<CMIUtilString> VecString_t;
 
     // Static method:
   public:
     static CMIUtilString Format(const CMIUtilString vFormating, ...);
     static CMIUtilString FormatBinary(const MIuint64 vnDecimal);
     static CMIUtilString FormatValist(const CMIUtilString &vrFormating, va_list vArgs);
-    static bool IsAllValidAlphaAndNumeric(const MIchar &vrText);
+    static bool IsAllValidAlphaAndNumeric(const MIchar *vpText);
     static bool Compare(const CMIUtilString &vrLhs, const CMIUtilString &vrRhs);
     static CMIUtilString ConvertToPrintableASCII(const char vChar);
     static CMIUtilString ConvertToPrintableASCII(const char16_t vChar16);
     static CMIUtilString ConvertToPrintableASCII(const char32_t vChar32);
 
     // Methods:
   public:
     /* ctor */ CMIUtilString(void);

lldb/trunk/tools/lldb-mi/MIUtilString.cpp

CMIUtilString::ExtractNumberFromHexadecimal(MIint64 &vwrNumber) const
 
     return true;
 }
 
 //++ ------------------------------------------------------------------------------------
 // Details: Determine if the text is all valid alpha numeric characters. Letters can be
 //          either upper or lower case.
 // Type:    Static method.
-// Args:    vrText  - (R) The text data to examine.
+// Args:    vpText  - (R) The text data to examine.
 // Return:  bool - True = yes all alpha, false = one or more chars is non alpha.
 // Throws:  None.
 //--
 bool
-CMIUtilString::IsAllValidAlphaAndNumeric(const MIchar &vrText)
+CMIUtilString::IsAllValidAlphaAndNumeric(const MIchar *vpText)
 {
-    const MIuint len = ::strlen(&vrText);
+    const MIuint len = ::strlen(vpText);
     if (len == 0)
         return false;
 
-    MIchar *pPtr = const_cast<MIchar *>(&vrText);
-    for (MIuint i = 0; i < len; i++, pPtr++)
+    for (MIuint i = 0; i < len; i++, vpText++)
     {
-        const MIchar c = *pPtr;
+        const MIchar c = *vpText;
         if (::isalnum((int)c) == 0)
             return false;
     }
 
     return true;
 }
 
 //++ ------------------------------------------------------------------------------------