This is an archive of the discontinued LLVM Phabricator instance.

Differential D10879

[BitcodeReader] Rangify some loops.
ClosedPublic

Authored by philip.pfaffe on Jul 1 2015, 12:59 PM.

Details

Reviewers
filcab
• rafael
Summary

No functional change.

Diff Detail

Event Timeline

philip.pfaffe updated this revision to Diff 28890.Jul 1 2015, 12:59 PM
philip.pfaffe retitled this revision from to [BitcodeReader] Rangify some loops..
philip.pfaffe updated this object.
philip.pfaffe edited the test plan for this revision. (Show Details)
philip.pfaffe added reviewers: • rafael, filcab.
philip.pfaffe added a subscriber: Unknown Object (MLST).
filcab accepted this revision.Jul 1 2015, 11:31 PM
filcab edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Jul 1 2015, 11:31 PM
philip.pfaffe closed this revision.Jul 2 2015, 10:13 AM

Commited in rL241279

Revision Contents

PathSize
lib/
Bitcode/
Reader/
30 lines

Diff 28890

lib/Bitcode/Reader/BitcodeReader.cpp

Context not available.
stripDebugInfo(*F); stripDebugInfo(*F);
// Upgrade any old intrinsic calls in the function. // Upgrade any old intrinsic calls in the function.
for (UpgradedIntrinsicMap::iterator I = UpgradedIntrinsics.begin(), for (auto &I : UpgradedIntrinsics) {
E = UpgradedIntrinsics.end(); I != E; ++I) { if (I.first != I.second) {
if (I->first != I->second) { for (auto *U : I.first->users()) {
for (auto UI = I->first->user_begin(), UE = I->first->user_end(); if (CallInst *CI = dyn_cast<CallInst>(U))
UI != UE;) { UpgradeIntrinsicCall(CI, I.second);
if (CallInst* CI = dyn_cast<CallInst>(*UI++))
UpgradeIntrinsicCall(CI, I->second);
} }
} }
} }
Context not available.
// delete the old functions to clean up. We can't do this unless the entire // delete the old functions to clean up. We can't do this unless the entire
// module is materialized because there could always be another function body // module is materialized because there could always be another function body
// with calls to the old function. // with calls to the old function.
for (std::vector<std::pair<Function*, Function*> >::iterator I = for (auto &I : UpgradedIntrinsics) {
UpgradedIntrinsics.begin(), E = UpgradedIntrinsics.end(); I != E; ++I) { if (I.first != I.second) {
if (I->first != I->second) { for (auto *U : I.first->users()) {
for (auto UI = I->first->user_begin(), UE = I->first->user_end(); if (CallInst *CI = dyn_cast<CallInst>(U))
UI != UE;) { UpgradeIntrinsicCall(CI, I.second);
if (CallInst* CI = dyn_cast<CallInst>(*UI++))
UpgradeIntrinsicCall(CI, I->second);
} }
if (!I->first->use_empty()) if (!I.first->use_empty())
I->first->replaceAllUsesWith(I->second); I.first->replaceAllUsesWith(I.second);
I->first->eraseFromParent(); I.first->eraseFromParent();
} }
} }
std::vector<std::pair<Function*, Function*> >().swap(UpgradedIntrinsics); std::vector<std::pair<Function*, Function*> >().swap(UpgradedIntrinsics);
Context not available.