This is an archive of the discontinued LLVM Phabricator instance.

Disable buffering for raw_null_ostream()
Needs ReviewPublic

Authored by mehdi_amini on Jun 30 2015, 10:40 PM.

This revision needs review, but all specified reviewers are disabled or inactive.

Reviewers

• espindola

Summary

There is no need to buffer the nulls() output.
Moreover it kept a shared buffer, and made using nulls() not possible
in a multi-threaded environment.

mehdi_amini retitled this revision from to Disable buffering for raw_null_ostream().

mehdi_amini updated this object.

mehdi_amini edited the test plan for this revision. (Show Details)

mehdi_amini added a subscriber: Unknown Object (MLST).

Take Duncan review into account

Split refactoring in D10885, leaving only the functional change for nulls() here.

Path

Size

include/

llvm/

Support/

2 lines

Show First 20 Lines • Show All 524 Lines • ▼ Show 20 Lines	class raw_null_ostream : public raw_pwrite_stream {
void write_impl(const char *Ptr, size_t size) override;		void write_impl(const char *Ptr, size_t size) override;
void pwrite_impl(const char *Ptr, size_t Size, uint64_t Offset) override;		void pwrite_impl(const char *Ptr, size_t Size, uint64_t Offset) override;

/// Return the current position within the stream, not counting the bytes		/// Return the current position within the stream, not counting the bytes
/// currently in the buffer.		/// currently in the buffer.
uint64_t current_pos() const override;		uint64_t current_pos() const override;

public:		public:
explicit raw_null_ostream() {}		explicit raw_null_ostream() : raw_pwrite_stream(StreamMode::Unbuffered) {}
~raw_null_ostream() override;		~raw_null_ostream() override;
};		};

class buffer_ostream : public raw_svector_ostream {		class buffer_ostream : public raw_svector_ostream {
raw_ostream &OS;		raw_ostream &OS;
SmallVector<char, 0> Buffer;		SmallVector<char, 0> Buffer;

public:		public:
Show All 9 Lines