Fix assertion when passing function into inline asm's input operand

[jasonliuMTK]

Summary

This seem to be a regression caused by this change: https://reviews.llvm.org/D60943.
Since we delayed report the error, we would run into some invalid state in clang and llvm.

Without this fix, clang would assert when passing function into inline asm's input operand.
If building without assertion, we would see segfault in llvm: https://godbolt.org/z/hb4acs8aG

This is essentially a partial reverse of this commit: https://github.com/llvm/llvm-project/commit/d68b2d043865e1c106432f2ab9c1b99a5a2ba86e

[jasonliuMTK]

Fix CI build.

[jasonliuMTK]

Gentle ping.

[void]

Wouldn't it be better to check if it's an argument to an inline asm block instead?

[rjmccall]

This is a reasonable assertion; the bug should be fixed on the caller side. Probably Sema should be performing function-to-pointer decay on r-value asm operands.

[jasonliuMTK]

Thanks for the comments. I will try to seek a solution on the Sema side.

[jasonliuMTK]

Try another approach.

[jasonliuMTK]

@void @rjmccall
I took a look at the Sema, and thought that inlining won't turn a function into a constant. So it might be okay to detect this error case earlier, instead of decaying to pointer and propagate the error to a later stage.
What do you think?

[rjmccall]

I think the right approach here is that, in the non l-value case (i.e. having not passed if (Info.allowsMemory() && !Info.allowsRegister())), you should be doing DefaultFunctionArrayLvalueConversion regardless of whether the operand requires a constant, and then you can do the check for a constant as a follow-up to that. As it is, the bug is that you're bypassing DefaultFunctionArrrayLvalueConversion when the operand requires a constant, and that's just wrong.

[jasonliuMTK]

Address comments.

[rjmccall]

Thanks, that looks a lot better.

clang/lib/Sema/SemaStmtAsm.cpp

401–420

The constant evaluator is fairly permissive about r-values, but still, you should probably update InputExpr here, too.

[jasonliuMTK]

@rjmccall
Thanks John. Hopefully that addressed the concern.

[rjmccall]

It does, thanks. LGTM

clang/lib/Sema/SemaStmtAsm.cpp

for (unsigned i = NumOutputs, e = NumOutputs + NumInputs; i != e; i++) {
 
     // Only allow void types for memory constraints.
     if (Info.allowsMemory() && !Info.allowsRegister()) {
       if (CheckAsmLValue(InputExpr, *this))
         return StmtError(Diag(InputExpr->getBeginLoc(),
                               diag::err_asm_invalid_lvalue_in_input)
                          << Info.getConstraintStr()
                          << InputExpr->getSourceRange());
-    } else if (Info.requiresImmediateConstant() && !Info.allowsRegister()) {
+    } else {
+      ExprResult Result = DefaultFunctionArrayLvalueConversion(Exprs[i]);
+      if (Result.isInvalid())
+        return StmtError();
+
+      InputExpr = Exprs[i] = Result.get();
+
+      if (Info.requiresImmediateConstant() && !Info.allowsRegister()) {
         if (!InputExpr->isValueDependent()) {
           Expr::EvalResult EVResult;
           if (InputExpr->EvaluateAsRValue(EVResult, Context, true)) {
             // For compatibility with GCC, we also allow pointers that would be
             // integral constant expressions if they were cast to int.
             llvm::APSInt IntResult;
             if (EVResult.Val.toIntegralConstant(IntResult, InputExpr->getType(),
                                                 Context))
               if (!Info.isValidAsmImmediate(IntResult))
-              return StmtError(Diag(InputExpr->getBeginLoc(),
-                                    diag::err_invalid_asm_value_for_constraint)
-                               << toString(IntResult, 10)
-                               << Info.getConstraintStr()
-                               << InputExpr->getSourceRange());
+                return StmtError(
+                    Diag(InputExpr->getBeginLoc(),
+                    << toString(IntResult, 10) << Info.getConstraintStr()
           }
         }
-
-    } else {
-      ExprResult Result = DefaultFunctionArrayLvalueConversion(Exprs[i]);
-      if (Result.isInvalid())
-        return StmtError();
-
-      Exprs[i] = Result.get();
+      }
     }
 
     if (Info.allowsRegister()) {
       if (InputExpr->getType()->isVoidType()) {
         return StmtError(
             Diag(InputExpr->getBeginLoc(), diag::err_asm_invalid_type_in_input)
             << InputExpr->getType() << Info.getConstraintStr()
             << InputExpr->getSourceRange());

clang/test/CodeGen/asm-call-func.c

+// RUN: %clang_cc1 -emit-llvm %s -o - -triple x86_64-unknown-linux-gnu| FileCheck %s
+
+void callee(void);
+void caller() {
+  //CHECK: call void asm sideeffect "rcall $0", "n,~{dirflag},~{fpsr},~{flags}"(void ()* @callee)
+  asm("rcall %0" ::"n"(callee));
+}