This is an archive of the discontinued LLVM Phabricator instance.

Use filename instead of index in test
ClosedPublic

Authored by Eric on Aug 2 2021, 10:58 AM.

Details

Summary

In some environments this test could fail if start.S has its own DWARF CompileUnit or similar are included before the DWARF CompileUnit for the file.
This change makes the test independent of the index of the compile unit, instead checking the filename.

Diff Detail

Event Timeline

Eric created this revision.Aug 2 2021, 10:58 AM
Eric requested review of this revision.Aug 2 2021, 10:58 AM
herhut accepted this revision.Aug 2 2021, 11:00 AM
herhut added a subscriber: herhut.

Thanks!

This revision is now accepted and ready to land.Aug 2 2021, 11:00 AM
jankratochvil accepted this revision.Aug 2 2021, 11:06 AM

s/if symbols for start.S or similar are included before the symbols for the file./if start.S has its own DWARF CompileUnit or similar are included before the DWARF CompileUnit for the file./

You could IMO check it in as an obvious fix, thanks.

Eric edited the summary of this revision. (Show Details)Aug 2 2021, 11:12 AM

Thanks for the quick review! Please commit it as I do not have permission to do that.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2021, 12:13 PM