This is an archive of the discontinued LLVM Phabricator instance.

Make locale code compile on CloudABI.
ClosedPublic

Authored by ed on Jun 25 2015, 3:22 AM.

Details

Summary

After D10690 lands, libc++'s locale code will compile on CloudABI, with the exception of the following two bits:

  • CloudABI doesn't have setlocale(), as the C library does not keep track of any global state. The global locale is always set to "C". Disable the call to setlocale() on this system.
  • Similarly, mbtowc_l() is also not present, as it is also not thread-safe. As CloudABI does not support state-dependent encodings, simply disable that part of the logic.

After D10690 and this patch hit the tree, the locale code will compile out of the box on CloudABI.

Diff Detail

Repository
rL LLVM

Event Timeline

ed updated this revision to Diff 28444.Jun 25 2015, 3:22 AM
ed retitled this revision from to Make locale code compile on CloudABI..
ed updated this object.
ed edited the test plan for this revision. (Show Details)
ed added reviewers: jroelofs, mclow.lists.
ed set the repository for this revision to rL LLVM.
ed added a subscriber: Unknown Object (MLST).
ed added a reviewer: EricWF.Jun 30 2015, 8:02 AM
ed added a comment.Jul 6 2015, 7:57 AM

Friendly ping! :-)

jroelofs accepted this revision.Jul 6 2015, 8:17 AM
jroelofs edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jul 6 2015, 8:17 AM
ed closed this revision.Jul 6 2015, 9:30 AM