This is an archive of the discontinued LLVM Phabricator instance.

clang-format some of the files in lib/Driver. NFC
ClosedPublic

Authored by dougk on Jun 24 2015, 7:08 AM.

Details

Summary

Precursor to some renaming of NaCl_TC etc as requested in http://reviews.llvm.org/D10609

Nothing was hand edited afterward except some literal strings that were poorly broken.

Diff Detail

Repository
rL LLVM

Event Timeline

dougk updated this revision to Diff 28340.Jun 24 2015, 7:08 AM
dougk retitled this revision from to clang-format some of the files in lib/Driver. NFC.
dougk updated this object.
dougk edited the test plan for this revision. (Show Details)
dougk added a reviewer: chandlerc.
dougk added a subscriber: Unknown Object (MLST).
silvas added a subscriber: silvas.Jun 24 2015, 5:23 PM
silvas added inline comments.
lib/Driver/Driver.cpp
1255–1256 ↗(On Diff #28340)

Quick drive-by comment: A few of these formatting changes are iterator for loops that could be range-for'ified. Would be nice to do that cleanup where possible.

chandlerc accepted this revision.Jun 26 2015, 1:06 AM
chandlerc edited edge metadata.

LGTM with a trivial comment tweak below.

lib/Driver/Driver.cpp
1255–1256 ↗(On Diff #28340)

While I agree, I'm happy for Doug to leave that to a later cleanup (or to leave that cleanup for another). This will at least reduce the (currently substantial) noise in code reviews from incidental formatting changes.

lib/Driver/ToolChains.cpp
3544–3546 ↗(On Diff #28340)

Re-flow this comment block?

lib/Driver/Tools.cpp
5507–5508 ↗(On Diff #28340)

This comment is so bad it blows my mind.

This revision is now accepted and ready to land.Jun 26 2015, 1:06 AM
This revision was automatically updated to reflect the committed changes.
dougk added inline comments.Jun 26 2015, 8:48 AM
lib/Driver/Driver.cpp
1255–1256 ↗(On Diff #28340)

Submitted separately.

lib/Driver/ToolChains.cpp
3544–3546 ↗(On Diff #28340)

Done

lib/Driver/Tools.cpp
5507–5508 ↗(On Diff #28340)

I don't know what it means either, but I'll leave it for the original author of r146413.