This is an archive of the discontinued LLVM Phabricator instance.

[mips] [IAS] Add support for the .set oddspreg/nooddspreg directives.
ClosedPublic

Authored by tomatabacu on Jun 23 2015, 9:49 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

tomatabacu updated this revision to Diff 28253.Jun 23 2015, 9:49 AM
tomatabacu retitled this revision from to [mips] [IAS] Add support for the .set oddspreg/nooddspreg directives..
tomatabacu updated this object.
tomatabacu edited the test plan for this revision. (Show Details)
tomatabacu added a reviewer: dsanders.
tomatabacu added subscribers: mpf, Unknown Object (MLST).
dsanders added inline comments.Jun 25 2015, 7:48 AM
test/MC/Mips/set-oddspreg-nooddspreg-bad.s
1 ↗(On Diff #28253)

The other *-bad.s tests are testing that invalid directives are rejected. This test seems to be checking that valid '.set oddspreg' directives work as intended.

6 ↗(On Diff #28253)

It's probably best to be less strict on the column.

tomatabacu updated this revision to Diff 28466.Jun 25 2015, 8:01 AM

Addressed review comments.

dsanders accepted this revision.Jun 29 2015, 2:45 AM
dsanders edited edge metadata.

LGTM with the CHECK-NOT corrected.

test/MC/Mips/set-oddspreg-nooddspreg-error.s
6 ↗(On Diff #28466)

Deleting the number will prevent it ever matching. You need a regex '{{[0-9]+}}'.

This revision is now accepted and ready to land.Jun 29 2015, 2:45 AM
This revision was automatically updated to reflect the committed changes.