This is an archive of the discontinued LLVM Phabricator instance.

Teach Clang about the PPC64 memory sanitizer implementation.
ClosedPublic

Authored by foad on Jun 23 2015, 5:40 AM.

Diff Detail

Event Timeline

foad updated this revision to Diff 28229.Jun 23 2015, 5:40 AM
foad retitled this revision from to Teach Clang about the PPC64 memory sanitizer implementation..
foad updated this object.
foad edited the test plan for this revision. (Show Details)
foad added reviewers: kcc, samsonov, eugenis, willschm.
foad added a subscriber: Unknown Object (MLST).
samsonov edited edge metadata.Jun 23 2015, 10:35 AM

Please add a test case.

foad added a comment.Jun 24 2015, 2:09 AM

Please add a test case.

What sort of test are you thinking of? Something like the existing test/Driver/asan.c ?

foad updated this revision to Diff 28332.Jun 24 2015, 5:16 AM
foad edited edge metadata.

Add a test case.

Sorry for not being clear. I actually meant test case added to test/Driver/fsanitize.c that would check that -fsanitize=memory is passed to clang-cc1 if we use target powerpc.

foad updated this revision to Diff 28401.Jun 24 2015, 2:03 PM

Test that -fsanitize=memory is passed to clang-cc1.

foad added a comment.Jun 24 2015, 2:04 PM

Sorry for not being clear. I actually meant test case added to test/Driver/fsanitize.c that would check that -fsanitize=memory is passed to clang-cc1 if we use target powerpc.

OK, done. Shall I keep the new msan.c test as well, now that I've written it?

samsonov accepted this revision.Jun 24 2015, 2:37 PM
samsonov edited edge metadata.

LGTM. Sure, why not.

test/Driver/fsanitize.c
263

CHECK-POWERPC-SANM

This revision is now accepted and ready to land.Jun 24 2015, 2:37 PM
foad closed this revision.Jun 25 2015, 3:35 AM