This is an archive of the discontinued LLVM Phabricator instance.

[LoopDist] Move loop-versioning helper functions to Cloning, NFC
ClosedPublic

Authored by anemet on Jun 19 2015, 2:58 PM.

Details

Summary

This makes them available to the LoopVersioning class as that is moved
to its own module in the next patch.

Diff Detail

Event Timeline

anemet updated this revision to Diff 28051.Jun 19 2015, 2:58 PM
anemet retitled this revision from to [LoopDist] Move loop-versioning helper functions to Cloning, NFC.
anemet updated this object.
anemet edited the test plan for this revision. (Show Details)
anemet added reviewers: hfinkel, ashutosh.nema.
anemet added a subscriber: Unknown Object (MLST).
hfinkel added inline comments.Jun 22 2015, 6:30 PM
include/llvm/Transforms/Utils/Cloning.h
248

Does it only include the preheader if the preheader is included in the Blocks list?

lib/Transforms/Utils/CloneFunction.cpp
726

Why not just name this remapInstructionsInBlocks?

anemet updated this revision to Diff 28307.Jun 23 2015, 5:09 PM

Address review comments:

Change remapInstructionsInLoop to remapInstructionsInBlocks

hfinkel accepted this revision.Jul 8 2015, 5:24 PM
hfinkel edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Jul 8 2015, 5:24 PM
This revision was automatically updated to reflect the committed changes.