Page MenuHomePhabricator

Fix duplicate shared module list entries
ClosedPublic

Authored by ADodds on Jun 17 2015, 3:20 AM.

Details

Summary

The POSIX DYLD has a fault causing it to duplicate all of the shared module entries twice. This happens because DYLDRendezvous::TakeSnapshot is called twice upon attach, and it appends to the list each time, rather then replacing its contents. This is fixed by clearing the list before taking a new snapshot.

Diff Detail

Repository
rL LLVM

Event Timeline

ADodds updated this revision to Diff 27821.Jun 17 2015, 3:20 AM
ADodds retitled this revision from to Fix duplicate shared module list entries.
ADodds updated this object.
ADodds edited the test plan for this revision. (Show Details)
ADodds added a reviewer: clayborg.
ADodds set the repository for this revision to rL LLVM.
ADodds added subscribers: Unknown Object (MLST), domipheus.
clayborg accepted this revision.Jun 17 2015, 10:13 AM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Jun 17 2015, 10:13 AM
This revision was automatically updated to reflect the committed changes.