This is an archive of the discontinued LLVM Phabricator instance.

r239199
ClosedPublic

Authored by Eugene.Zelenko on Jun 8 2015, 3:12 PM.

Download Raw Diff

Details

Reviewers

• tstellarAMD
clayborg

Commits

rGd70b42472f17: Merging r239199: --------------------------------------------------------------…
rL240294: Merging r239199:

Summary

Remove unused editline includes

LLDB included editline in a couple of places, not respecting LLDB_DISABLE_LIBEDIT.

Diff Detail

Repository: rL LLVM

Event Timeline

Eugene.Zelenko updated this revision to Diff 27337.Jun 8 2015, 3:12 PM

Eugene.Zelenko retitled this revision from to r239199.

Eugene.Zelenko updated this object.

Eugene.Zelenko edited the test plan for this revision. (Show Details)

Eugene.Zelenko added a reviewer: • tstellarAMD.

Eugene.Zelenko added a project: Restricted Project.

Herald added a subscriber: tberghammer. · View Herald TranscriptJun 8 2015, 3:12 PM

Hi Greg,

Is this patch OK to merge to the 3.6 branch?

Looks good.

This revision is now accepted and ready to land.Jun 15 2015, 3:42 PM

Closed by commit rL240294: Merging r239199: (authored by tstellar). · Explain WhyJun 22 2015, 9:51 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lldb/

branches/

release_36/

tools/

driver/

Platform.h

10 lines

lldb-mi/

Platform.h

7 lines

Diff 28122

lldb/branches/release_36

The contents of this file were not changed.

lldb/branches/release_36/tools/driver/Platform.h

Show First 20 Lines • Show All 97 Lines • ▼ Show 20 Lines	#else

#include <libgen.h>		#include <libgen.h>
#include <sys/ioctl.h>		#include <sys/ioctl.h>
#include <termios.h>		#include <termios.h>
#include <unistd.h>		#include <unistd.h>

#include <pthread.h>		#include <pthread.h>
#include <sys/time.h>		#include <sys/time.h>

#if !defined(__ANDROID_NDK__)
#include <histedit.h>
#if defined(__FreeBSD__) \|\| defined(__NetBSD__)
#include <readline/readline.h>
#else
#include <editline/readline.h>
#endif
#endif

#endif		#endif

#endif // lldb_Platform_h_		#endif // lldb_Platform_h_

lldb/branches/release_36/tools/lldb-mi/Platform.h

	Show First 20 Lines • Show All 90 Lines • ▼ Show 20 Lines
	#include <inttypes.h>			#include <inttypes.h>

	#include <getopt.h>			#include <getopt.h>
	#include <libgen.h>			#include <libgen.h>
	#include <sys/ioctl.h>			#include <sys/ioctl.h>
	#include <termios.h>			#include <termios.h>
	#include <unistd.h>			#include <unistd.h>

	#include <histedit.h>
	#include <pthread.h>			#include <pthread.h>
	#include <sys/time.h>			#include <sys/time.h>

	#if defined(__FreeBSD__)
	#include <readline/readline.h>
	#else
	#include <editline/readline.h>
	#endif

	#endif			#endif