[lldbtest] Use netloc instead of hostname to look up Android device ID.

[sivachandra]

Summary

urlparse.ParseResult.hostname has only lowercase characters even if the
input URL had uppercase characters. Since Android device IDs can have
uppercase characters as well, use urlparse.ParseResult.netloc instead
and extract the device ID from it.

This change also improves the error message when lookup of the Android
device's API fails.

[chaoren]

test/lldbtest.py

449–451

lldb.platform_url.startswith?

450

I would prefer if we delegated as much parsing as possible to urlparse.
We can check parsed.scheme and use parsed.netloc.split(':')[0] as hostname.

[chaoren]

test/lldbtest.py

448

I don't think it's possible to not have a platform url here. Return false if not lldb.platform_url?

[sivachandra]

Address comments.

[chaoren]

LGTM

test/lldbtest.py

def run_adb_command(cmd, device_id):
     if device_id:
         device_id_args = ["-s", device_id]
     full_cmd = ["adb"] + device_id_args + cmd
     p = Popen(full_cmd, stdout=PIPE, stderr=PIPE)
     stdout, stderr = p.communicate()
     return p.returncode, stdout, stderr
 
 def android_device_api():
+    assert lldb.platform_url is not None
     device_id = None
-    if lldb.platform_url:
-        parsed = urlparse.urlparse(lldb.platform_url)
-        if parsed.scheme == "adb":
-            device_id = parsed.hostname
+    parsed_url = urlparse.urlparse(lldb.platform_url)
+    if parsed_url.scheme == "adb":
+        device_id = parsed_url.netloc.split(":")[0]
     retcode, stdout, stderr = run_adb_command(
         ["shell", "getprop", "ro.build.version.sdk"], device_id)
     if retcode == 0:
         return int(stdout)
     else:
         raise LookupError(
-            "Unable to determine the API level of the Android device.")
+            ">>> Unable to determine the API level of the Android device.\n"
+            ">>> stdout:\n%s\n"
+            ">>> stderr:\n%s\n" % (stdout, stderr))
 
 #
 # Decorators for categorizing test cases.
 #
 
 from functools import wraps
 def python_api_test(func):
     """Decorate the item as a Python API only test."""