This is an archive of the discontinued LLVM Phabricator instance.

Differential D10223

Change big 'if' statement into a switch. NFC
ClosedPublic

Authored by dougk on Jun 3 2015, 11:30 AM.

Details

Reviewers
bkramer
Commits
rG7ae27b88dd5f: Change big 'if' statement into a switch. NFC
rC238955: Change big 'if' statement into a switch. NFC
rL238955: Change big 'if' statement into a switch. NFC

Diff Detail

Repository
rL LLVM

Event Timeline

dougk updated this revision to Diff 27056.Jun 3 2015, 11:30 AM
dougk retitled this revision from to Change big 'if' statement into a switch. NFC.
dougk updated this object.
dougk edited the test plan for this revision. (Show Details)
dougk added a subscriber: Unknown Object (MLST).
bkramer accepted this revision.Jun 3 2015, 11:40 AM
bkramer added a reviewer: bkramer.
bkramer added a subscriber: bkramer.

Looks good. Feel free to check in trivial changes like this for post-commit review.

This revision is now accepted and ready to land.Jun 3 2015, 11:40 AM
Closed by commit rL238955: Change big 'if' statement into a switch. NFC (authored by dougk). · Explain WhyJun 3 2015, 12:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
lib/
Driver/
35 lines

Diff 27059

cfe/trunk/lib/Driver/ToolChains.cpp

Show First 20 Lines • Show All 2,071 Lines • ▼ Show 20 Linesbool Generic_GCC::isPIEDefault() const {
return false; return false;
} }
bool Generic_GCC::isPICDefaultForced() const { bool Generic_GCC::isPICDefaultForced() const {
return false; return false;
} }
bool Generic_GCC::IsIntegratedAssemblerDefault() const { bool Generic_GCC::IsIntegratedAssemblerDefault() const {
return getTriple().getArch() == llvm::Triple::x86 || switch (getTriple().getArch()) {
getTriple().getArch() == llvm::Triple::x86_64 || case llvm::Triple::x86:
getTriple().getArch() == llvm::Triple::aarch64 || case llvm::Triple::x86_64:
getTriple().getArch() == llvm::Triple::aarch64_be || case llvm::Triple::aarch64:
getTriple().getArch() == llvm::Triple::arm || case llvm::Triple::aarch64_be:
getTriple().getArch() == llvm::Triple::armeb || case llvm::Triple::arm:
getTriple().getArch() == llvm::Triple::thumb || case llvm::Triple::armeb:
getTriple().getArch() == llvm::Triple::thumbeb || case llvm::Triple::thumb:
getTriple().getArch() == llvm::Triple::ppc || case llvm::Triple::thumbeb:
getTriple().getArch() == llvm::Triple::ppc64 || case llvm::Triple::ppc:
getTriple().getArch() == llvm::Triple::ppc64le || case llvm::Triple::ppc64:
getTriple().getArch() == llvm::Triple::sparc || case llvm::Triple::ppc64le:
getTriple().getArch() == llvm::Triple::sparcel || case llvm::Triple::sparc:
getTriple().getArch() == llvm::Triple::sparcv9 || case llvm::Triple::sparcel:
getTriple().getArch() == llvm::Triple::systemz; case llvm::Triple::sparcv9:
case llvm::Triple::systemz:
return true;
default:
return false;
}
} }
void Generic_ELF::addClangTargetOptions(const ArgList &DriverArgs, void Generic_ELF::addClangTargetOptions(const ArgList &DriverArgs,
ArgStringList &CC1Args) const { ArgStringList &CC1Args) const {
const Generic_GCC::GCCVersion &V = GCCInstallation.getVersion(); const Generic_GCC::GCCVersion &V = GCCInstallation.getVersion();
bool UseInitArrayDefault = bool UseInitArrayDefault =
getTriple().getArch() == llvm::Triple::aarch64 || getTriple().getArch() == llvm::Triple::aarch64 ||
getTriple().getArch() == llvm::Triple::aarch64_be || getTriple().getArch() == llvm::Triple::aarch64_be ||
▲ Show 20 Lines • Show All 1,624 Lines • Show Last 20 Lines