This is an archive of the discontinued LLVM Phabricator instance.

add ConstEvaluatedExprVisitor
ClosedPublic

Authored by scott-0 on Jun 3 2015, 3:39 AM.

Details

Summary

Adds a version of EvaluatedExprVisitor for visiting const Stmt*s and uses it in a few places thereby removing some casting away of const. Changes EvaluatedExprVisitor to hold it's ASTContext& as const and adds a few 'const's that this allows. Removes an spurious #include.

Overall, no functional change. I'm also going to use ConstEvaluatedExprVisitor in a subsequent patch about side-effect of StmtExprs.

Diff Detail

Repository
rL LLVM

Event Timeline

scott-0 updated this revision to Diff 27029.Jun 3 2015, 3:39 AM
scott-0 retitled this revision from to add ConstEvaluatedExprVisitor.
scott-0 updated this object.
scott-0 edited the test plan for this revision. (Show Details)
scott-0 added a subscriber: Unknown Object (MLST).
rs added a subscriber: rs.Jun 3 2015, 5:31 AM

LGTM, but someone else should approve as well

rsmith accepted this revision.Jun 5 2015, 12:16 PM
rsmith added a reviewer: rsmith.
rsmith added a subscriber: rsmith.

LGTM

llvm/tools/clang/include/clang/AST/EvaluatedExprVisitor.h
34 ↗(On Diff #27029)

No blank line here.

114 ↗(On Diff #27029)

Likewise.

124 ↗(On Diff #27029)

Likewise.

This revision is now accepted and ready to land.Jun 5 2015, 12:16 PM
This revision was automatically updated to reflect the committed changes.