Check before using platform specific attributes.

[chaoren]

Summary

os.uname in TestUniversal and os.geteuid in TestTerminal.

[zturner]

test/functionalities/tty/TestTerminal.py

15–18 ↗

(On Diff #27011)

FWIW, Windows currently *only* supports launching a program in a separate terminal window. At the risk of introducing another failing test on the Windows side, I wonder if we could turn this test on for Windows.

30 ↗

(On Diff #27011)

Doh, nevermind.

[chaoren]

• Check availability before using os.uname in TestUniversal.

[chaoren]

Formatting.

[zturner]

Looks good

lldb/trunk/test/functionalities/tty/TestTerminal.py

class LaunchInTerminalTestCase(TestBase):
     # Darwin is the only platform that I know of that supports optionally launching
     # a program in a separate terminal window. It would be great if other platforms
     # added support for this.
     @skipUnlessDarwin
 
 
     # If the test is being run under sudo, the spawned terminal won't retain that elevated
     # privilege so it can't open the socket to talk back to the test case
-    @unittest2.skipUnless(os.geteuid() != 0, "test cannot be run as root")
+    @unittest2.skipUnless(not hasattr(os, 'geteuid') or os.geteuid() != 0,
+            "test cannot be run as root")
 
     # Do we need to disable this test if the testsuite is being run on a remote system?
     # This env var is only defined when the shell is running in a local mac terminal window
     @unittest2.skipUnless(os.environ.has_key('TERM_PROGRAM'), "test must be run on local system")
 
     def test_launch_in_terminal (self):
         exe = "/bin/ls"
         target = self.dbg.CreateTarget(exe)

lldb/trunk/test/macosx/universal/TestUniversal.py

class UniversalTestCase(TestBase):
     def setUp(self):
         # Call super's setUp().
         TestBase.setUp(self)
         # Find the line number to break inside main().
         self.line = line_number('main.c', '// Set break point at this line.')
 
     @python_api_test
     @skipUnlessDarwin
-    @unittest2.skipUnless(os.uname()[4] in ['i386', 'x86_64'], "requires i386 or x86_64")
+    @unittest2.skipUnless(hasattr(os, "uname") and os.uname()[4] in ['i386', 'x86_64'],
+            "requires i386 or x86_64")
     def test_sbdebugger_create_target_with_file_and_target_triple(self):
         """Test the SBDebugger.CreateTargetWithFileAndTargetTriple() API."""
         # Invoke the default build rule.
         self.buildDefault()
 
         # Note that "testit" is a universal binary.
         exe = os.path.join(os.getcwd(), "testit")
 
         # Create a target by the debugger.
         target = self.dbg.CreateTargetWithFileAndTargetTriple(exe, "i386-apple-macosx")
         self.assertTrue(target, VALID_TARGET)
 
         # Now launch the process, and do not stop at entry point.
         process = target.LaunchSimple (None, None, self.get_process_working_directory())
         self.assertTrue(process, PROCESS_IS_VALID)
 
     @skipUnlessDarwin
-    @unittest2.skipUnless(os.uname()[4] in ['i386', 'x86_64'], "requires i386 or x86_64")
+    @unittest2.skipUnless(hasattr(os, "uname") and os.uname()[4] in ['i386', 'x86_64'],
+            "requires i386 or x86_64")
     def test_process_launch_for_universal(self):
         """Test process launch of a universal binary."""
         from lldbutil import print_registers
 
         # Invoke the default build rule.
         self.buildDefault()
 
         # Note that "testit" is a universal binary.