This is an archive of the discontinued LLVM Phabricator instance.

Add isConstant argument to MDBuilder::createTBAAStructTagNode
ClosedPublic

Authored by apilipenko on Jun 1 2015, 6:04 AM.

Details

Summary

According to the TBAA description struct-path tag node can have an optional IsConstant field. Add corresponding argument to MDBuilder::createTBAAStructTagNode.

Diff Detail

Event Timeline

apilipenko updated this revision to Diff 26896.Jun 1 2015, 6:04 AM
apilipenko retitled this revision from to Add isConstant argument to MDBuilder::createTBAAStructTagNode.
apilipenko updated this object.
apilipenko edited the test plan for this revision. (Show Details)
apilipenko added a subscriber: Unknown Object (MLST).
hfinkel added a subscriber: hfinkel.Jun 1 2015, 6:12 AM
hfinkel added inline comments.
lib/IR/MDBuilder.cpp
174

Please only add the extra parameter if it is true. Let's not increase the memory footprint of the metadata for the common case.

apilipenko updated this revision to Diff 26898.Jun 1 2015, 6:27 AM
hfinkel accepted this revision.Jun 1 2015, 6:46 AM
hfinkel added a reviewer: hfinkel.

LGTM.

This revision is now accepted and ready to land.Jun 1 2015, 6:46 AM
This revision was automatically updated to reflect the committed changes.