This is an archive of the discontinued LLVM Phabricator instance.

Simplify regex in TestDataFormatterUnordered.py for better readability.
ClosedPublic

Authored by chaoren on May 28 2015, 10:39 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

chaoren updated this revision to Diff 26702.May 28 2015, 10:39 AM
chaoren retitled this revision from to Simplify regex in TestDataFormatterUnordered.py for better readability..
chaoren updated this object.
chaoren edited the test plan for this revision. (Show Details)
chaoren added reviewers: sivachandra, clayborg.
chaoren added a subscriber: Unknown Object (MLST).
sivachandra accepted this revision.May 28 2015, 12:31 PM
sivachandra edited edge metadata.
sivachandra added inline comments.
test/functionalities/data-formatter/data-formatter-stl/libcxx/unordered/TestDataFormatterUnordered.py
64 ↗(On Diff #26702)

I don't really care about this, but if you really want to improve the readability while sticking to PEP8, add an empty line between each of the self.look_for_content_and_continue(...) calls. Further, Each line could be like this:

self.look_for_content_and_continue(
    "map",
    ['size=5 {', 'hello', 'world', 'this', 'is', 'me'])

Also, add a note like "Improve readability around these changes while at it" in the commit message.

As I said above, I really don't care you make these changes or not.

This revision is now accepted and ready to land.May 28 2015, 12:31 PM
This revision was automatically updated to reflect the committed changes.