Prevent building of libunwind, libcxx, libcxxabi, and lld on powerpc64 buildbots

[seurer]

Summary

libunwind, libcxx, libcxxabi, and lld are not supported (and do not work) on powerpc64 (neither BE nor LE). However, they are always included in the code that the sanitizer buildbots fetch and compile. Changes made to them sometimes cause the powerpc64 buildbots to stop working until someone (like me) goes in and corrects the compilation problems. Until they are supported they need to be removed from what the powerpc64 buildbots fetch and build.

Checking the BUILDBOT_BUILDERNAME environment variable in buildbot_functions.sh was the simplest way I could see to do this and also let me try out the changes locally on the powerpc64 buildbots before submitting this revision.

[eugenis]

Could you please do this with less code duplication?
Like SUBDIRS=xxx
if (PPC64) SUBDIRS=$SUBDIRS yyy
for tree in $SUBDIRS

and the same with build targets.

[seurer]

How does that look?

[eugenis]

zorg/buildbot/builders/sanitizers/buildbot_functions.sh

160–169

Missing ${extra_dirs} in this line?
You probably want to skip this step completely on PPC64.

[seurer]

zorg/buildbot/builders/sanitizers/buildbot_functions.sh

160–169

Oops, yeah. I will change this to just skip the whole thing.

[seurer]

Updated diff

[eugenis]

LGTM

[seurer]

Committed http://reviews.llvm.org/rL238230

[eugenis]

And I think you broke this:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/4176

[seurer]

+ subdirs='llvm llvm/tools/clang llvm/projects/compiler-rt'
+ llvm/projects/libcxx llvm/projects/libcxxabi llvm/tools/lld
/mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/sanitizer_buildbot/sanitizers/buildbot_functions.sh: line 23: llvm/projects/libcxx: Is a directory

if [ "$BUILDBOT_BUILDERNAME" != "sanitizer-ppc64-linux1" -a "$BUILDBOT_BUILDERNAME" != "sanitizer-ppc64le-linux" ]; then
  subdirs=${subdirs} llvm/projects/libcxx llvm/projects/libcxxabi llvm/tools/lld
fi

It looks like that is the line that broke things. Should the right hand side be in quotes?

if [ "$BUILDBOT_BUILDERNAME" != "sanitizer-ppc64-linux1" -a "$BUILDBOT_BUILDERNAME" != "sanitizer-ppc64le-linux" ]; then
  subdirs="${subdirs} llvm/projects/libcxx llvm/projects/libcxxabi llvm/tools/lld"
fi

[eugenis]

Yeah, probably.

[seurer]

http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/4184/steps/update/logs/stdio

It looks like that fixed things.

zorg/buildbot/builders/sanitizers/buildbot_functions.sh

 }
 
 function buildbot_update {
     local rev_arg=
     if [ "$BUILDBOT_REVISION" != "" ]; then
         rev_arg="-r$BUILDBOT_REVISION"
     fi
     local tree
-    for tree in llvm llvm/tools/clang llvm/projects/compiler-rt llvm/projects/libcxx llvm/projects/libcxxabi llvm/tools/lld
+    # Currently we do not want to fetch nor build libunwind, libcxx, libcxxabi, and lld on powerpc64 buildbots
+    local subdirs="llvm llvm/tools/clang llvm/projects/compiler-rt"
+    if [ "$BUILDBOT_BUILDERNAME" != "sanitizer-ppc64-linux1" -a "$BUILDBOT_BUILDERNAME" != "sanitizer-ppc64le-linux" ]; then
+      subdirs=${subdirs} llvm/projects/libcxx llvm/projects/libcxxabi llvm/tools/lld
+    fi
+    for tree in ${subdirs}
     do
       if [ -d ${tree} ]; then
         svn cleanup "${tree}"
       fi
     done
 
     update_or_checkout "$rev_arg" http://llvm.org/svn/llvm-project/llvm/trunk llvm
 
     if [ "$rev_arg" == "" ]; then
         rev_arg="-r"$(svn info llvm | grep '^Revision:' | awk '{print $2}')
     fi
 
     # XXX: Keep this list in sync with the change filter in buildbot/osuosl/master/master.cfg.
     update_or_checkout "$rev_arg" http://llvm.org/svn/llvm-project/cfe/trunk llvm/tools/clang
     update_or_checkout "$rev_arg" http://llvm.org/svn/llvm-project/compiler-rt/trunk llvm/projects/compiler-rt
+    # Currently we do not want to fetch nor build libunwind, libcxx, libcxxabi, and lld on powerpc64 buildbots
+    if [ "$BUILDBOT_BUILDERNAME" != "sanitizer-ppc64-linux1" -a "$BUILDBOT_BUILDERNAME" != "sanitizer-ppc64le-linux" ]; then
       update_or_checkout "$rev_arg" http://llvm.org/svn/llvm-project/libcxx/trunk llvm/projects/libcxx
       update_or_checkout "$rev_arg" http://llvm.org/svn/llvm-project/libcxxabi/trunk llvm/projects/libcxxabi
       update_or_checkout "$rev_arg" http://llvm.org/svn/llvm-project/libunwind/trunk llvm/projects/libunwind
       update_or_checkout "$rev_arg" http://llvm.org/svn/llvm-project/lld/trunk llvm/tools/lld
+    fi
 }
 
 function set_chrome_suid_sandbox {
   export CHROME_DEVEL_SANDBOX=/usr/local/sbin/chrome-devel-sandbox
 }
 
 function fetch_depot_tools {
   ROOT=$1
elif [ "$sanitizer_name" == "ubsan" ]; then
     local fsanitize_flag="-fsanitize=undefined"
     local build_type="Debug"
   else
     echo "Unknown sanitizer!"
     exit 1
   fi
 
   mkdir -p ${libcxx_build_dir}
+  # Currently we do not want to fetch nor build libunwind, libcxx, libcxxabi, and lld on powerpc64 buildbots
+  if [ "$BUILDBOT_BUILDERNAME" != "sanitizer-ppc64-linux1" -a "$BUILDBOT_BUILDERNAME" != "sanitizer-ppc64le-linux" ]; then
     (cd ${libcxx_build_dir} && \
       cmake \
         ${cmake_stage2_common_options} \
         -DCMAKE_BUILD_TYPE=${build_type} \
         -DLLVM_USE_SANITIZER=${llvm_use_sanitizer} \
         $LLVM && \
       ninja cxx cxxabi) || echo $step_result
+  fi
 
   echo @@@BUILD_STEP build clang/$sanitizer_name@@@
 
   local sanitizer_ldflags="-lc++abi -Wl,--rpath=${ROOT}/${libcxx_build_dir}/lib -L${ROOT}/${libcxx_build_dir}/lib"
   # See http://llvm.org/bugs/show_bug.cgi?id=19071, http://www.cmake.org/Bug/view.php?id=15264
   local cmake_bug_workaround_cflags="$sanitizer_ldflags $fsanitize_flag -w"
   local sanitizer_cflags="-I${ROOT}/${libcxx_build_dir}/include -I${ROOT}/${libcxx_build_dir}/include/c++/v1 $cmake_bug_workaround_cflags"
   mkdir -p ${build_dir}
+  # Currently we do not want to fetch nor build libunwind, libcxx, libcxxabi, and lld on powerpc64 buildbots
+  local extra_dir
+  if [ "$BUILDBOT_BUILDERNAME" != "sanitizer-ppc64-linux1" -a "$BUILDBOT_BUILDERNAME" != "sanitizer-ppc64le-linux" ]; then
+    extra_dir=lld
+  fi
   (cd ${build_dir} && \
    cmake ${cmake_stage2_common_options} \
      -DCMAKE_BUILD_TYPE=${build_type} \
      -DLLVM_USE_SANITIZER=${llvm_use_sanitizer} \
      -DLLVM_ENABLE_LIBCXX=ON \
      -DCMAKE_C_FLAGS="${sanitizer_cflags}" \
      -DCMAKE_CXX_FLAGS="${sanitizer_cflags}" \
      -DCMAKE_EXE_LINKER_FLAGS="${sanitizer_ldflags}" \
      $LLVM && \
-   ninja clang lld) || echo $step_result
+   ninja clang ${extra_dir}) || echo $step_result
 }
 
 function build_stage2_msan {
   build_stage2 msan "${STAGE2_LIBCXX_MSAN_DIR}" "${STAGE2_MSAN_DIR}" @@@STEP_FAILURE@@@
 }
 
 function build_stage2_asan {
   build_stage2 asan "${STAGE2_LIBCXX_ASAN_DIR}" "${STAGE2_ASAN_DIR}" @@@STEP_FAILURE@@@
function check_stage2 {
   echo @@@BUILD_STEP check-llvm ${sanitizer_name}@@@
 
   (cd ${build_dir} && ninja check-llvm) || echo $step_result
 
   echo @@@BUILD_STEP check-clang ${sanitizer_name}@@@
 
   (cd ${build_dir} && ninja check-clang) || echo $step_result
 
+  # Currently we do not want to fetch nor build libunwind, libcxx, libcxxabi, and lld on powerpc64 buildbots
+  if [ "$BUILDBOT_BUILDERNAME" != "sanitizer-ppc64-linux1" -a "$BUILDBOT_BUILDERNAME" != "sanitizer-ppc64le-linux" ]; then
     echo @@@BUILD_STEP check-lld ${sanitizer_name}@@@
 
     # TODO(smatveev): change this to STEP_FAILURE once green
     (cd ${build_dir} && ninja check-lld) || echo @@@STEP_WARNINGS@@@
+  fi
 }
 
 function check_stage2_msan {
   check_stage2 msan "${STAGE2_MSAN_DIR}" @@@STEP_FAILURE@@@
 }
 
 function check_stage2_asan {
   check_stage2 asan "${STAGE2_ASAN_DIR}" @@@STEP_FAILURE@@@
 }
 
 function check_stage2_ubsan {
   # TODO(samsonov): change this to STEP_FAILURE once green
   check_stage2 ubsan "${STAGE2_UBSAN_DIR}" @@@STEP_WARNINGS@@@
 }