This is an archive of the discontinued LLVM Phabricator instance.

Refactor: Simplify boolean conditional return statements in tools/yaml2obj
AbandonedPublic

Authored by LegalizeAdulthood on May 25 2015, 12:04 PM.

Details

Summary

Use clang-tidy to simplify boolean conditional return statements

Diff Detail

Event Timeline

LegalizeAdulthood retitled this revision from to Refactor: Simplify boolean conditional return statements in tools/yaml2obj.
LegalizeAdulthood updated this object.
LegalizeAdulthood edited the test plan for this revision. (Show Details)
LegalizeAdulthood added a subscriber: Unknown Object (MLST).
atanasyan added inline comments.May 25 2015, 9:54 PM
tools/yaml2obj/yaml2coff.cpp
117

Might be the following code even better?

return parseSections() && parseSymbols();
silvas edited edge metadata.May 27 2015, 6:30 PM

The way it already is makes it immediately clear that this is forwarding errors, and immediately indicates what the sense of the error bool is. The suggested alternatives require head scratching/digging around. I vote to keep it as-is.

LegalizeAdulthood abandoned this revision.Oct 24 2015, 1:20 PM