This is an archive of the discontinued LLVM Phabricator instance.

Refactor: Simplify boolean conditional return statements in tools/llvm-symbolizer
ClosedPublic

Authored by LegalizeAdulthood on May 25 2015, 12:02 PM.

Reviewers

Summary

Use clang-tidy to simplify boolean conditional return statements

LegalizeAdulthood retitled this revision from to Refactor: Simplify boolean conditional return statements in tools/llvm-symbolizer.

LegalizeAdulthood updated this object.

LegalizeAdulthood edited the test plan for this revision. (Show Details)

LegalizeAdulthood added a subscriber: Unknown Object (MLST).

LGTM

This revision is now accepted and ready to land.May 26 2015, 6:54 AM

I don't have commit access, so someone will need to commit this for me.

Applied in r251216

Path

Size

tools/

llvm-symbolizer/

4 lines

Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Lines	if (pos == '"' \|\| pos == '\'') {
pos += name_length;		pos += name_length;
}		}
} else {		} else {
ModuleName = ClBinaryName;		ModuleName = ClBinaryName;
}		}
// Skip delimiters and parse module offset.		// Skip delimiters and parse module offset.
pos += strspn(pos, kDelimiters);		pos += strspn(pos, kDelimiters);
int offset_length = strcspn(pos, kDelimiters);		int offset_length = strcspn(pos, kDelimiters);
if (StringRef(pos, offset_length).getAsInteger(0, ModuleOffset))		return !StringRef(pos, offset_length).getAsInteger(0, ModuleOffset);
return false;
return true;
}		}

int main(int argc, char **argv) {		int main(int argc, char **argv) {
// Print stack trace if we signal out.		// Print stack trace if we signal out.
sys::PrintStackTraceOnErrorSignal();		sys::PrintStackTraceOnErrorSignal();
PrettyStackTraceProgram X(argc, argv);		PrettyStackTraceProgram X(argc, argv);
llvm_shutdown_obj Y; // Call llvm_shutdown() on exit.		llvm_shutdown_obj Y; // Call llvm_shutdown() on exit.

Show All 29 Lines