Refactor: Simplify boolean expressions in tools/llvm-objdump

[LegalizeAdulthood]

Summary

Use clang-tidy to simplify boolean expressions

[• rafael]

LGTM

[LegalizeAdulthood]

Update to latest.
I do not have commit access.

[LegalizeAdulthood]

I do not have commit access, so someone else will need to commit this. Let me know if it needs rebasing.

Patch by Richard Thomson.

[LegalizeAdulthood]

Discarding due to inaction by reviewers.

tools/llvm-objdump/MachODump.cpp

if (n_value != 0) {
     if (cro.baseProperties != 0)
       outs() << " + " << format("0x%" PRIx64, cro.baseProperties);
   } else
     outs() << format("0x%" PRIx64, cro.baseProperties);
   outs() << "\n";
   if (cro.baseProperties + n_value != 0)
     print_objc_property_list64(cro.baseProperties + n_value, info);
 
-  is_meta_class = (cro.flags & RO_META) ? true : false;
+  is_meta_class = (cro.flags & RO_META) != 0;
   return true;
 }
 
 static bool print_class_ro32_t(uint32_t p, struct DisassembleInfo *info,
                                bool &is_meta_class) {
   struct class_ro32_t cro;
   const char *r;
   uint32_t offset, xoffset, left;
if (cro.ivars != 0)
     print_ivar_list32_t(cro.ivars, info);
   outs() << "           weakIvarLayout "
          << format("0x%" PRIx32, cro.weakIvarLayout) << "\n";
   print_layout_map32(cro.weakIvarLayout, info);
   outs() << "           baseProperties "
          << format("0x%" PRIx32, cro.baseProperties) << "\n";
   if (cro.baseProperties != 0)
     print_objc_property_list32(cro.baseProperties, info);
-  is_meta_class = (cro.flags & RO_META) ? true : false;
+  is_meta_class = (cro.flags & RO_META) != 0;
   return true;
 }
 
 static void print_class64_t(uint64_t p, struct DisassembleInfo *info) {
   struct class64_t c;
   const char *r;
   uint32_t offset, left;
   SectionRef S;