[clangd] Handle OverloadExpr in targetDecl

ilya-biryukov · ilya-biryukov · commit a160a0ba5313 · 2019-10-01T07:27:55.000Z
Reviewers: sammccall Reviewed By: sammccall Subscribers: nridge, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D68119 llvm-svn: 373305
diff --git a/clang-tools-extra/clangd/FindTarget.cpp b/clang-tools-extra/clangd/FindTarget.cpp
@@ -189,6 +189,10 @@ struct TargetFinder {
           D = USD;
         Outer.add(D, Flags);
       }
+      void VisitOverloadExpr(const OverloadExpr *OE) {
+        for (auto *D : OE->decls())
+          Outer.add(D, Flags);
+      }
       void VisitCXXConstructExpr(const CXXConstructExpr *CCE) {
         Outer.add(CCE->getConstructor(), Flags);
       }
diff --git a/clang-tools-extra/clangd/unittests/FindTargetTests.cpp b/clang-tools-extra/clangd/unittests/FindTargetTests.cpp
@@ -393,6 +393,32 @@ TEST_F(TargetDeclTest, Lambda) {
   EXPECT_DECLS("DeclRefExpr", "auto int x = 1");
 }
 
+TEST_F(TargetDeclTest, OverloadExpr) {
+  Code = R"cpp(
+    void func(int*);
+    void func(char*);
+
+    template <class T>
+    void foo(T t) {
+      [[func]](t);
+    };
+  )cpp";
+  EXPECT_DECLS("UnresolvedLookupExpr", "void func(int *)", "void func(char *)");
+
+  Code = R"cpp(
+    struct X {
+      void func(int*);
+      void func(char*);
+    };
+
+    template <class T>
+    void foo(X x, T t) {
+      x.[[func]](t);
+    };
+  )cpp";
+  EXPECT_DECLS("UnresolvedMemberExpr", "void func(int *)", "void func(char *)");
+}
+
 TEST_F(TargetDeclTest, ObjC) {
   Flags = {"-xobjective-c"};
   Code = R"cpp(

Original file line number	Diff line number	Diff line change
`@@ -189,6 +189,10 @@ struct TargetFinder {`
`189`	`189`	`D = USD;`
`190`	`190`	`Outer.add(D, Flags);`
`191`	`191`	`}`
	`192`	`+ void VisitOverloadExpr(const OverloadExpr *OE) {`
	`193`	`+ for (auto *D : OE->decls())`
	`194`	`+ Outer.add(D, Flags);`
	`195`	`+ }`
`192`	`196`	`void VisitCXXConstructExpr(const CXXConstructExpr *CCE) {`
`193`	`197`	`Outer.add(CCE->getConstructor(), Flags);`
`194`	`198`	`}`