[CMake] Allow LLVM_EXTERNAL_<proj>_SOURCE_DIR to be overridden if it is

Yuanfang Chen · Yuanfang Chen · commit f184ce53a7cb · 2019-07-26T19:25:57.000Z
empty. This makes adding projects to LLVM_ENABLE_PROJECTS possible. Also its type should be PATH. https://bugs.llvm.org/show_bug.cgi?id=42698 Reviewers: beanz, greened, chapuni Reviewed by: beanz Differential Revision: https://reviews.llvm.org/D65045 llvm-svn: 367144
diff --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt
@@ -95,7 +95,11 @@ if (LLVM_ENABLE_PROJECTS_USED OR NOT LLVM_ENABLE_PROJECTS STREQUAL "")
       if(NOT EXISTS "${PROJ_DIR}" OR NOT IS_DIRECTORY "${PROJ_DIR}")
         message(FATAL_ERROR "LLVM_ENABLE_PROJECTS requests ${proj} but directory not found: ${PROJ_DIR}")
       endif()
-      set(LLVM_EXTERNAL_${upper_proj}_SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/../${proj}" CACHE STRING "")
+      if( LLVM_EXTERNAL_${upper_proj}_SOURCE_DIR STREQUAL "" )
+        set(LLVM_EXTERNAL_${upper_proj}_SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/../${proj}" CACHE PATH "" FORCE)
+      else()
+        set(LLVM_EXTERNAL_${upper_proj}_SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/../${proj}" CACHE PATH "")
+      endif()
     elseif ("${proj}" IN_LIST LLVM_EXTERNAL_PROJECTS)
       message(STATUS "${proj} project is enabled")
       set(SHOULD_ENABLE_PROJECT TRUE)
