Skip to content

Commit

Permalink
[X86] Move InstPrinter files to MCTargetDesc. NFC
Browse files Browse the repository at this point in the history
For some targets, there is a circular dependency between InstPrinter and
MCTargetDesc.  Merging them together will fix this.  For the other targets,
the merging is to maintain consistency so all targets will have the same
structure.

llvm-svn: 360484
Weverything committed May 10, 2019
1 parent 1e3b789 commit b28b8b7
Showing 22 changed files with 33 additions and 58 deletions.
2 changes: 1 addition & 1 deletion llvm/lib/Target/X86/AsmParser/LLVMBuild.txt
Original file line number Diff line number Diff line change
@@ -18,5 +18,5 @@
type = Library
name = X86AsmParser
parent = X86
required_libraries = MC MCParser Support X86Desc X86Info X86AsmPrinter
required_libraries = MC MCParser Support X86Desc X86Info
add_to_library_groups = X86
2 changes: 1 addition & 1 deletion llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
Original file line number Diff line number Diff line change
@@ -6,8 +6,8 @@
//
//===----------------------------------------------------------------------===//

#include "InstPrinter/X86IntelInstPrinter.h"
#include "MCTargetDesc/X86BaseInfo.h"
#include "MCTargetDesc/X86IntelInstPrinter.h"
#include "MCTargetDesc/X86MCExpr.h"
#include "MCTargetDesc/X86TargetStreamer.h"
#include "X86AsmParserCommon.h"
2 changes: 1 addition & 1 deletion llvm/lib/Target/X86/AsmParser/X86Operand.h
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@
#ifndef LLVM_LIB_TARGET_X86_ASMPARSER_X86OPERAND_H
#define LLVM_LIB_TARGET_X86_ASMPARSER_X86OPERAND_H

#include "InstPrinter/X86IntelInstPrinter.h"
#include "MCTargetDesc/X86IntelInstPrinter.h"
#include "MCTargetDesc/X86MCTargetDesc.h"
#include "X86AsmParserCommon.h"
#include "llvm/ADT/STLExtras.h"
1 change: 0 additions & 1 deletion llvm/lib/Target/X86/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -74,7 +74,6 @@ add_llvm_target(X86CodeGen ${sources})

add_subdirectory(AsmParser)
add_subdirectory(Disassembler)
add_subdirectory(InstPrinter)
add_subdirectory(MCTargetDesc)
add_subdirectory(TargetInfo)
add_subdirectory(Utils)
6 changes: 0 additions & 6 deletions llvm/lib/Target/X86/InstPrinter/CMakeLists.txt

This file was deleted.

22 changes: 0 additions & 22 deletions llvm/lib/Target/X86/InstPrinter/LLVMBuild.txt

This file was deleted.

4 changes: 2 additions & 2 deletions llvm/lib/Target/X86/LLVMBuild.txt
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
;===------------------------------------------------------------------------===;

[common]
subdirectories = AsmParser Disassembler InstPrinter MCTargetDesc TargetInfo Utils
subdirectories = AsmParser Disassembler MCTargetDesc TargetInfo Utils

[component_0]
type = TargetGroup
@@ -30,5 +30,5 @@ has_jit = 1
type = Library
name = X86CodeGen
parent = X86
required_libraries = Analysis AsmPrinter CodeGen Core MC SelectionDAG Support Target X86AsmPrinter X86Desc X86Info X86Utils GlobalISel ProfileData
required_libraries = Analysis AsmPrinter CodeGen Core MC SelectionDAG Support Target X86Desc X86Info X86Utils GlobalISel ProfileData
add_to_library_groups = X86
4 changes: 4 additions & 0 deletions llvm/lib/Target/X86/MCTargetDesc/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
add_llvm_library(LLVMX86Desc
X86ATTInstPrinter.cpp
X86IntelInstPrinter.cpp
X86InstComments.cpp
X86InstPrinterCommon.cpp
X86AsmBackend.cpp
X86MCTargetDesc.cpp
X86MCAsmInfo.cpp
2 changes: 1 addition & 1 deletion llvm/lib/Target/X86/MCTargetDesc/LLVMBuild.txt
Original file line number Diff line number Diff line change
@@ -18,5 +18,5 @@
type = Library
name = X86Desc
parent = X86
required_libraries = MC MCDisassembler Object Support X86AsmPrinter X86Info
required_libraries = MC MCDisassembler Object Support X86Info X86Utils
add_to_library_groups = X86
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@
//===----------------------------------------------------------------------===//

#include "X86ATTInstPrinter.h"
#include "MCTargetDesc/X86BaseInfo.h"
#include "X86BaseInfo.h"
#include "X86InstComments.h"
#include "llvm/MC/MCExpr.h"
#include "llvm/MC/MCInst.h"
Original file line number Diff line number Diff line change
@@ -10,8 +10,8 @@
//
//===----------------------------------------------------------------------===//

#ifndef LLVM_LIB_TARGET_X86_INSTPRINTER_X86ATTINSTPRINTER_H
#define LLVM_LIB_TARGET_X86_INSTPRINTER_X86ATTINSTPRINTER_H
#ifndef LLVM_LIB_TARGET_X86_MCTARGETDESC_X86ATTINSTPRINTER_H
#define LLVM_LIB_TARGET_X86_MCTARGETDESC_X86ATTINSTPRINTER_H

#include "X86InstPrinterCommon.h"

@@ -121,4 +121,4 @@ class X86ATTInstPrinter final : public X86InstPrinterCommon {

} // end namespace llvm

#endif // LLVM_LIB_TARGET_X86_INSTPRINTER_X86ATTINSTPRINTER_H
#endif // LLVM_LIB_TARGET_X86_MCTARGETDESC_X86ATTINSTPRINTER_H
Original file line number Diff line number Diff line change
@@ -13,8 +13,8 @@

#include "X86InstComments.h"
#include "X86ATTInstPrinter.h"
#include "MCTargetDesc/X86BaseInfo.h"
#include "MCTargetDesc/X86MCTargetDesc.h"
#include "X86BaseInfo.h"
#include "X86MCTargetDesc.h"
#include "Utils/X86ShuffleDecode.h"
#include "llvm/MC/MCInst.h"
#include "llvm/MC/MCInstrInfo.h"
Original file line number Diff line number Diff line change
@@ -11,8 +11,8 @@
//
//===----------------------------------------------------------------------===//

#ifndef LLVM_LIB_TARGET_X86_INSTPRINTER_X86INSTCOMMENTS_H
#define LLVM_LIB_TARGET_X86_INSTPRINTER_X86INSTCOMMENTS_H
#ifndef LLVM_LIB_TARGET_X86_MCTARGETDESC_X86INSTCOMMENTS_H
#define LLVM_LIB_TARGET_X86_MCTARGETDESC_X86INSTCOMMENTS_H

namespace llvm {

Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@
//===----------------------------------------------------------------------===//

#include "X86InstPrinterCommon.h"
#include "MCTargetDesc/X86BaseInfo.h"
#include "X86BaseInfo.h"
#include "llvm/MC/MCExpr.h"
#include "llvm/MC/MCInst.h"
#include "llvm/MC/MCInstrDesc.h"
Original file line number Diff line number Diff line change
@@ -11,8 +11,8 @@
//
//===----------------------------------------------------------------------===//

#ifndef LLVM_LIB_TARGET_X86_INSTPRINTER_X86INSTPRINTERCOMMON_H
#define LLVM_LIB_TARGET_X86_INSTPRINTER_X86INSTPRINTERCOMMON_H
#ifndef LLVM_LIB_TARGET_X86_MCTARGETDESC_X86INSTPRINTERCOMMON_H
#define LLVM_LIB_TARGET_X86_MCTARGETDESC_X86INSTPRINTERCOMMON_H

#include "llvm/MC/MCInstPrinter.h"

@@ -37,4 +37,4 @@ class X86InstPrinterCommon : public MCInstPrinter {

} // end namespace llvm

#endif // LLVM_LIB_TARGET_X86_INSTPRINTER_X86ATTINSTPRINTER_H
#endif // LLVM_LIB_TARGET_X86_MCTARGETDESC_X86ATTINSTPRINTER_H
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@
//===----------------------------------------------------------------------===//

#include "X86IntelInstPrinter.h"
#include "MCTargetDesc/X86BaseInfo.h"
#include "X86BaseInfo.h"
#include "X86InstComments.h"
#include "llvm/MC/MCExpr.h"
#include "llvm/MC/MCInst.h"
Original file line number Diff line number Diff line change
@@ -10,8 +10,8 @@
//
//===----------------------------------------------------------------------===//

#ifndef LLVM_LIB_TARGET_X86_INSTPRINTER_X86INTELINSTPRINTER_H
#define LLVM_LIB_TARGET_X86_INSTPRINTER_X86INTELINSTPRINTER_H
#ifndef LLVM_LIB_TARGET_X86_MCTARGETDESC_X86INTELINSTPRINTER_H
#define LLVM_LIB_TARGET_X86_MCTARGETDESC_X86INTELINSTPRINTER_H

#include "X86InstPrinterCommon.h"
#include "llvm/Support/raw_ostream.h"
@@ -141,4 +141,4 @@ class X86IntelInstPrinter final : public X86InstPrinterCommon {

} // end namespace llvm

#endif // LLVM_LIB_TARGET_X86_INSTPRINTER_X86INTELINSTPRINTER_H
#endif // LLVM_LIB_TARGET_X86_MCTARGETDESC_X86INTELINSTPRINTER_H
2 changes: 1 addition & 1 deletion llvm/lib/Target/X86/MCTargetDesc/X86MCExpr.h
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@
#ifndef LLVM_LIB_TARGET_X86_MCTARGETDESC_X86MCEXPR_H
#define LLVM_LIB_TARGET_X86_MCTARGETDESC_X86MCEXPR_H

#include "InstPrinter/X86ATTInstPrinter.h"
#include "X86ATTInstPrinter.h"
#include "llvm/MC/MCAsmInfo.h"
#include "llvm/MC/MCContext.h"
#include "llvm/MC/MCExpr.h"
4 changes: 2 additions & 2 deletions llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp
Original file line number Diff line number Diff line change
@@ -11,9 +11,9 @@
//===----------------------------------------------------------------------===//

#include "X86MCTargetDesc.h"
#include "InstPrinter/X86ATTInstPrinter.h"
#include "InstPrinter/X86IntelInstPrinter.h"
#include "X86ATTInstPrinter.h"
#include "X86BaseInfo.h"
#include "X86IntelInstPrinter.h"
#include "X86MCAsmInfo.h"
#include "llvm/ADT/APInt.h"
#include "llvm/ADT/Triple.h"
2 changes: 1 addition & 1 deletion llvm/lib/Target/X86/X86AsmPrinter.cpp
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@
//===----------------------------------------------------------------------===//

#include "X86AsmPrinter.h"
#include "InstPrinter/X86ATTInstPrinter.h"
#include "MCTargetDesc/X86ATTInstPrinter.h"
#include "MCTargetDesc/X86BaseInfo.h"
#include "MCTargetDesc/X86TargetStreamer.h"
#include "X86InstrInfo.h"
2 changes: 1 addition & 1 deletion llvm/lib/Target/X86/X86EvexToVex.cpp
Original file line number Diff line number Diff line change
@@ -19,8 +19,8 @@
//
//===----------------------------------------------------------------------===//

#include "InstPrinter/X86InstComments.h"
#include "MCTargetDesc/X86BaseInfo.h"
#include "MCTargetDesc/X86InstComments.h"
#include "X86.h"
#include "X86InstrInfo.h"
#include "X86Subtarget.h"
4 changes: 2 additions & 2 deletions llvm/lib/Target/X86/X86MCInstLower.cpp
Original file line number Diff line number Diff line change
@@ -11,9 +11,9 @@
//
//===----------------------------------------------------------------------===//

#include "InstPrinter/X86ATTInstPrinter.h"
#include "InstPrinter/X86InstComments.h"
#include "MCTargetDesc/X86ATTInstPrinter.h"
#include "MCTargetDesc/X86BaseInfo.h"
#include "MCTargetDesc/X86InstComments.h"
#include "MCTargetDesc/X86TargetStreamer.h"
#include "Utils/X86ShuffleDecode.h"
#include "X86AsmPrinter.h"

0 comments on commit b28b8b7

Please sign in to comment.