Revert "[Lexer] NFC: Fix an off-by-one bug in getAsCharRange()."

haoNoQ · haoNoQ · commit 4a9007cde74b · 2019-04-05T22:11:28.000Z
This reverts commit r357823. Was breaking clang-tidy! Differential Revision: https://reviews.llvm.org/D59977 llvm-svn: 357827
diff --git a/clang/include/clang/Basic/PlistSupport.h b/clang/include/clang/Basic/PlistSupport.h
@@ -127,11 +127,7 @@ inline void EmitRange(raw_ostream &o, const SourceManager &SM,
   assert(R.isCharRange() && "cannot handle a token range");
   Indent(o, indent) << "<array>\n";
   EmitLocation(o, SM, R.getBegin(), FM, indent + 1);
-
-  // The ".getLocWithOffset(-1)" emulates the behavior of an off-by-one bug
-  // in Lexer that is already fixed. It is here for backwards compatibility
-  // even though it is incorrect.
-  EmitLocation(o, SM, R.getEnd().getLocWithOffset(-1), FM, indent + 1);
+  EmitLocation(o, SM, R.getEnd(), FM, indent + 1);
   Indent(o, indent) << "</array>\n";
 }
 
diff --git a/clang/include/clang/Lex/Lexer.h b/clang/include/clang/Lex/Lexer.h
@@ -382,7 +382,7 @@ class Lexer : public PreprocessorLexer {
     SourceLocation End = getLocForEndOfToken(Range.getEnd(), 0, SM, LangOpts);
     return End.isInvalid() ? CharSourceRange()
                            : CharSourceRange::getCharRange(
-                                 Range.getBegin(), End);
+                                 Range.getBegin(), End.getLocWithOffset(-1));
   }
   static CharSourceRange getAsCharRange(CharSourceRange Range,
                                         const SourceManager &SM,
diff --git a/clang/unittests/Lex/LexerTest.cpp b/clang/unittests/Lex/LexerTest.cpp
@@ -513,23 +513,4 @@ TEST_F(LexerTest, StringizingRasString) {
   EXPECT_EQ(String6, R"(a\\\n\n\n    \\\\b)");
 }
 
-TEST_F(LexerTest, CharRangeOffByOne) {
-  std::vector<Token> toks = Lex(R"(#define MOO 1
-    void foo() { MOO; })");
-  const Token &moo = toks[5];
-
-  EXPECT_EQ(getSourceText(moo, moo), "MOO");
-
-  SourceRange R{moo.getLocation(), moo.getLocation()};
-
-  EXPECT_TRUE(
-      Lexer::isAtStartOfMacroExpansion(R.getBegin(), SourceMgr, LangOpts));
-  EXPECT_TRUE(
-      Lexer::isAtEndOfMacroExpansion(R.getEnd(), SourceMgr, LangOpts));
-
-  CharSourceRange CR = Lexer::getAsCharRange(R, SourceMgr, LangOpts);
-
-  EXPECT_EQ(Lexer::getSourceText(CR, SourceMgr, LangOpts), "MOO"); // Was "MO".
-}
-
 } // anonymous namespace

Original file line number	Diff line number	Diff line change
`@@ -382,7 +382,7 @@ class Lexer : public PreprocessorLexer {`
`382`	`382`	`SourceLocation End = getLocForEndOfToken(Range.getEnd(), 0, SM, LangOpts);`
`383`	`383`	`return End.isInvalid() ? CharSourceRange()`
`384`	`384`	`: CharSourceRange::getCharRange(`
`385`		`- Range.getBegin(), End);`
	`385`	`+ Range.getBegin(), End.getLocWithOffset(-1));`
`386`	`386`	`}`
`387`	`387`	`static CharSourceRange getAsCharRange(CharSourceRange Range,`
`388`	`388`	`const SourceManager &SM,`