Skip to content

Commit bf92b3f

Browse files
committedMar 12, 2019
llvm-objcopy: Remove unused field. NFCI.
Differential Revision: https://reviews.llvm.org/D59126 llvm-svn: 355892
1 parent 930d46a commit bf92b3f

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed
 

‎llvm/tools/llvm-objcopy/ELF/Object.cpp

+1-3
Original file line numberDiff line numberDiff line change
@@ -901,9 +901,7 @@ template <class ELFT> void ELFBuilder<ELFT>::setParentSegment(Segment &Child) {
901901
template <class ELFT> void ELFBuilder<ELFT>::readProgramHeaders() {
902902
uint32_t Index = 0;
903903
for (const auto &Phdr : unwrapOrError(ElfFile.program_headers())) {
904-
ArrayRef<uint8_t> Data{ElfFile.base() + Phdr.p_offset,
905-
(size_t)Phdr.p_filesz};
906-
Segment &Seg = Obj.addSegment(Data);
904+
Segment &Seg = Obj.addSegment();
907905
Seg.Type = Phdr.p_type;
908906
Seg.Flags = Phdr.p_flags;
909907
Seg.OriginalOffset = Phdr.p_offset;

‎llvm/tools/llvm-objcopy/ELF/Object.h

+2-6
Original file line numberDiff line numberDiff line change
@@ -312,10 +312,6 @@ class Segment {
312312
uint32_t Index;
313313
uint64_t OriginalOffset;
314314
Segment *ParentSegment = nullptr;
315-
ArrayRef<uint8_t> Contents;
316-
317-
explicit Segment(ArrayRef<uint8_t> Data) : Contents(Data) {}
318-
Segment() {}
319315

320316
const SectionBase *firstSection() const {
321317
if (!Sections.empty())
@@ -827,8 +823,8 @@ class Object {
827823
Ptr->Index = Sections.size();
828824
return *Ptr;
829825
}
830-
Segment &addSegment(ArrayRef<uint8_t> Data) {
831-
Segments.emplace_back(llvm::make_unique<Segment>(Data));
826+
Segment &addSegment() {
827+
Segments.emplace_back(llvm::make_unique<Segment>());
832828
return *Segments.back();
833829
}
834830
};

0 commit comments

Comments
 (0)
Please sign in to comment.