Remove redundant null pointer check in operator delete

MaskRay · MaskRay · commit 7cd67904f776 · 2018-10-01T17:21:07.000Z
Summary: C89 4.10.3.2 The free function C99 7.20.3.2 The free function C11 7.22.3.3 The free function If ptr is a null pointer, no action shall occur. _aligned_free on MSDN: If memblock is a NULL pointer, this function simply performs no actions. Reviewers: EricWF, mclow.lists, khng300, hotpxl Reviewed By: mclow.lists, khng300, hotpxl Subscribers: lichray, llvm-commits, hotpxl, khng300, christof, ldionne, cfe-commits, libcxx-commits Differential Revision: https://reviews.llvm.org/D52401 llvm-svn: 343503
diff --git a/libcxx/src/new.cpp b/libcxx/src/new.cpp
@@ -135,8 +135,7 @@ _LIBCPP_WEAK
 void
 operator delete(void* ptr) _NOEXCEPT
 {
-    if (ptr)
-        ::free(ptr);
+    ::free(ptr);
 }
 
 _LIBCPP_WEAK
@@ -257,11 +256,10 @@ _LIBCPP_WEAK
 void
 operator delete(void* ptr, std::align_val_t) _NOEXCEPT
 {
-    if (ptr)
 #if defined(_LIBCPP_MSVCRT_LIKE)
-        ::_aligned_free(ptr);
+    ::_aligned_free(ptr);
 #else
-        ::free(ptr);
+    ::free(ptr);
 #endif
 }
 

Original file line number	Diff line number	Diff line change
`@@ -135,8 +135,7 @@ _LIBCPP_WEAK`
`135`	`135`	`void`
`136`	`136`	`operator delete(void* ptr) _NOEXCEPT`
`137`	`137`	`{`
`138`		`- if (ptr)`
`139`		`- ::free(ptr);`
	`138`	`+ ::free(ptr);`
`140`	`139`	`}`
`141`	`140`
`142`	`141`	`_LIBCPP_WEAK`
`@@ -257,11 +256,10 @@ _LIBCPP_WEAK`
`257`	`256`	`void`
`258`	`257`	`operator delete(void* ptr, std::align_val_t) _NOEXCEPT`
`259`	`258`	`{`
`260`		`- if (ptr)`
`261`	`259`	`#if defined(_LIBCPP_MSVCRT_LIKE)`
`262`		`- ::_aligned_free(ptr);`
	`260`	`+ ::_aligned_free(ptr);`
`263`	`261`	`#else`
`264`		`- ::free(ptr);`
	`262`	`+ ::free(ptr);`
`265`	`263`	`#endif`
`266`	`264`	`}`
`267`	`265`