Skip to content

Commit 59de37b

Browse files
author
Eli Friedman
committedAug 24, 2018
[SafeStack] Set debug location for calls to __safestack_pointer_address.
Otherwise, the debug info is incorrect. On its own, this is mostly harmless, but the safe-stack also later inlines the call to __safestack_pointer_address, which leads to debug info with the wrong scope, which eventually causes an assertion failure (and incorrect debug info in release mode). Differential Revision: https://reviews.llvm.org/D51075 llvm-svn: 340651
1 parent 29729f1 commit 59de37b

File tree

2 files changed

+102
-0
lines changed

2 files changed

+102
-0
lines changed
 

‎llvm/lib/CodeGen/SafeStack.cpp

+4
Original file line numberDiff line numberDiff line change
@@ -775,6 +775,10 @@ bool SafeStack::run() {
775775
++NumUnsafeStackRestorePointsFunctions;
776776

777777
IRBuilder<> IRB(&F.front(), F.begin()->getFirstInsertionPt());
778+
// Calls must always have a debug location, or else inlining breaks. So
779+
// we explicitly set a artificial debug location here.
780+
if (DISubprogram *SP = F.getSubprogram())
781+
IRB.SetCurrentDebugLocation(DebugLoc::get(SP->getScopeLine(), 0, SP));
778782
if (SafeStackUsePointerAddress) {
779783
Value *Fn = F.getParent()->getOrInsertFunction(
780784
"__safestack_pointer_address", StackPtrTy->getPointerTo(0));

‎llvm/test/Transforms/SafeStack/ARM/debug.ll

+98
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
1+
; RUN: opt -safe-stack -safestack-use-pointer-address < %s -S | FileCheck %s
2+
target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"
3+
target triple = "armv7-pc-linux-android"
4+
5+
; Original C used to generate debug info:
6+
; char*** addr;
7+
; char** __safestack_pointer_address() {
8+
; return *addr;
9+
; }
10+
; void Capture(char*x);
11+
; void f() { char c[16]; Capture(c); }
12+
13+
; CHECK: !35 = !DILocation(line: 3, column: 11, scope: !17, inlinedAt: !36)
14+
; CHECK: !36 = distinct !DILocation(line: 6, scope: !27)
15+
16+
@addr = common local_unnamed_addr global i8*** null, align 4, !dbg !0
17+
18+
; Function Attrs: norecurse nounwind readonly safestack
19+
define i8** @__safestack_pointer_address() local_unnamed_addr #0 !dbg !17 {
20+
entry:
21+
%0 = load i8***, i8**** @addr, align 4, !dbg !20, !tbaa !21
22+
%1 = load i8**, i8*** %0, align 4, !dbg !25, !tbaa !21
23+
ret i8** %1, !dbg !26
24+
}
25+
26+
; Function Attrs: nounwind safestack
27+
define void @f() local_unnamed_addr #1 !dbg !27 {
28+
entry:
29+
%c = alloca [16 x i8], align 1
30+
%0 = getelementptr inbounds [16 x i8], [16 x i8]* %c, i32 0, i32 0, !dbg !35
31+
call void @llvm.lifetime.start.p0i8(i64 16, i8* nonnull %0) #5, !dbg !35
32+
call void @llvm.dbg.declare(metadata [16 x i8]* %c, metadata !31, metadata !DIExpression()), !dbg !36
33+
call void @Capture(i8* nonnull %0) #5, !dbg !37
34+
call void @llvm.lifetime.end.p0i8(i64 16, i8* nonnull %0) #5, !dbg !38
35+
ret void, !dbg !38
36+
}
37+
38+
; Function Attrs: argmemonly nounwind
39+
declare void @llvm.lifetime.start.p0i8(i64, i8* nocapture) #2
40+
41+
; Function Attrs: nounwind readnone speculatable
42+
declare void @llvm.dbg.declare(metadata, metadata, metadata) #3
43+
44+
declare void @Capture(i8*) local_unnamed_addr #4
45+
46+
; Function Attrs: argmemonly nounwind
47+
declare void @llvm.lifetime.end.p0i8(i64, i8* nocapture) #2
48+
49+
attributes #0 = { norecurse nounwind readonly safestack "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="generic" "target-features"="+armv7-a,+dsp,+neon,+vfp3,-thumb-mode" "unsafe-fp-math"="false" "use-soft-float"="false" }
50+
attributes #1 = { nounwind safestack "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="generic" "target-features"="+armv7-a,+dsp,+neon,+vfp3,-thumb-mode" "unsafe-fp-math"="false" "use-soft-float"="false" }
51+
attributes #2 = { argmemonly nounwind }
52+
attributes #3 = { nounwind readnone speculatable }
53+
attributes #4 = { "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="generic" "target-features"="+armv7-a,+dsp,+neon,+vfp3,-thumb-mode" "unsafe-fp-math"="false" "use-soft-float"="false" }
54+
attributes #5 = { nounwind }
55+
56+
!llvm.dbg.cu = !{!2}
57+
!llvm.module.flags = !{!11, !12, !13, !14, !15}
58+
!llvm.ident = !{!16}
59+
60+
!0 = !DIGlobalVariableExpression(var: !1, expr: !DIExpression())
61+
!1 = distinct !DIGlobalVariable(name: "addr", scope: !2, file: !6, line: 1, type: !7, isLocal: false, isDefinition: true)
62+
!2 = distinct !DICompileUnit(language: DW_LANG_C99, file: !3, producer: "clang", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !4, globals: !5)
63+
!3 = !DIFile(filename: "-", directory: "/")
64+
!4 = !{}
65+
!5 = !{!0}
66+
!6 = !DIFile(filename: "<stdin>", directory: "/")
67+
!7 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !8, size: 32)
68+
!8 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !9, size: 32)
69+
!9 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: !10, size: 32)
70+
!10 = !DIBasicType(name: "char", size: 8, encoding: DW_ATE_unsigned_char)
71+
!11 = !{i32 2, !"Dwarf Version", i32 4}
72+
!12 = !{i32 2, !"Debug Info Version", i32 3}
73+
!13 = !{i32 1, !"wchar_size", i32 4}
74+
!14 = !{i32 1, !"min_enum_size", i32 4}
75+
!15 = !{i32 7, !"PIC Level", i32 1}
76+
!16 = !{!"clang"}
77+
!17 = distinct !DISubprogram(name: "__safestack_pointer_address", scope: !6, file: !6, line: 2, type: !18, isLocal: false, isDefinition: true, scopeLine: 2, isOptimized: true, unit: !2, retainedNodes: !4)
78+
!18 = !DISubroutineType(types: !19)
79+
!19 = !{!8}
80+
!20 = !DILocation(line: 3, column: 11, scope: !17)
81+
!21 = !{!22, !22, i64 0}
82+
!22 = !{!"any pointer", !23, i64 0}
83+
!23 = !{!"omnipotent char", !24, i64 0}
84+
!24 = !{!"Simple C/C++ TBAA"}
85+
!25 = !DILocation(line: 3, column: 10, scope: !17)
86+
!26 = !DILocation(line: 3, column: 3, scope: !17)
87+
!27 = distinct !DISubprogram(name: "f", scope: !6, file: !6, line: 6, type: !28, isLocal: false, isDefinition: true, scopeLine: 6, isOptimized: true, unit: !2, retainedNodes: !30)
88+
!28 = !DISubroutineType(types: !29)
89+
!29 = !{null}
90+
!30 = !{!31}
91+
!31 = !DILocalVariable(name: "c", scope: !27, file: !6, line: 6, type: !32)
92+
!32 = !DICompositeType(tag: DW_TAG_array_type, baseType: !10, size: 128, elements: !33)
93+
!33 = !{!34}
94+
!34 = !DISubrange(count: 16)
95+
!35 = !DILocation(line: 6, column: 12, scope: !27)
96+
!36 = !DILocation(line: 6, column: 17, scope: !27)
97+
!37 = !DILocation(line: 6, column: 24, scope: !27)
98+
!38 = !DILocation(line: 6, column: 36, scope: !27)

0 commit comments

Comments
 (0)
Please sign in to comment.