[COFF] clean up global resources after completion

rui314 · rui314 · commit 279621fbf0ab · 2018-07-26T17:11:24.000Z
Patch by Andrew Kelley. Previously, running lld::coff::link() twice in the same process would access stale pointers because of these global variables not being reset. After this patch, lld::coff::link() can be called any number of times, just like its ELF and MACH-O counterparts. Differential Revision: https://reviews.llvm.org/D49856 llvm-svn: 338042
diff --git a/lld/COFF/Driver.cpp b/lld/COFF/Driver.cpp
@@ -75,6 +75,9 @@ bool link(ArrayRef<const char *> Args, bool CanExitEarly, raw_ostream &Diag) {
     exitLld(errorCount() ? 1 : 0);
 
   freeArena();
+  ObjFile::Instances.clear();
+  ImportFile::Instances.clear();
+  BitcodeFile::Instances.clear();
   return !errorCount();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,9 @@ bool link(ArrayRef<const char *> Args, bool CanExitEarly, raw_ostream &Diag) {`
`75`	`75`	`exitLld(errorCount() ? 1 : 0);`
`76`	`76`
`77`	`77`	`freeArena();`
	`78`	`+ ObjFile::Instances.clear();`
	`79`	`+ ImportFile::Instances.clear();`
	`80`	`+ BitcodeFile::Instances.clear();`
`78`	`81`	`return !errorCount();`
`79`	`82`	`}`
`80`	`83`