MC: Remove redundant substr() call

sbc100 · sbc100 · commit a81fb84811ae · 2018-05-30T03:37:26.000Z
Differential Revision: https://reviews.llvm.org/D47047 llvm-svn: 333496
diff --git a/llvm/lib/Object/MachOObjectFile.cpp b/llvm/lib/Object/MachOObjectFile.cpp
@@ -107,7 +107,7 @@ getSectionPtr(const MachOObjectFile &O, MachOObjectFile::LoadCommandInfo L,
 }
 
 static const char *getPtr(const MachOObjectFile &O, size_t Offset) {
-  return O.getData().substr(Offset, 1).data();
+  return O.getData().data() + Offset;
 }
 
 static MachO::nlist_base
diff --git a/llvm/lib/Object/WasmObjectFile.cpp b/llvm/lib/Object/WasmObjectFile.cpp
@@ -995,7 +995,7 @@ Error WasmObjectFile::parseDataSection(ReadContext &Ctx) {
 }
 
 const uint8_t *WasmObjectFile::getPtr(size_t Offset) const {
-  return reinterpret_cast<const uint8_t *>(getData().substr(Offset, 1).data());
+  return reinterpret_cast<const uint8_t *>(getData().data() + Offset);
 }
 
 const wasm::WasmObjectHeader &WasmObjectFile::getHeader() const {

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ getSectionPtr(const MachOObjectFile &O, MachOObjectFile::LoadCommandInfo L,`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`static const char *getPtr(const MachOObjectFile &O, size_t Offset) {`
`110`		`- return O.getData().substr(Offset, 1).data();`
	`110`	`+ return O.getData().data() + Offset;`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`static MachO::nlist_base`
Original file line number	Diff line number	Diff line change
`@@ -995,7 +995,7 @@ Error WasmObjectFile::parseDataSection(ReadContext &Ctx) {`
`995`	`995`	`}`
`996`	`996`
`997`	`997`	`const uint8_t *WasmObjectFile::getPtr(size_t Offset) const {`
`998`		`- return reinterpret_cast<const uint8_t *>(getData().substr(Offset, 1).data());`
	`998`	`+ return reinterpret_cast<const uint8_t *>(getData().data() + Offset);`
`999`	`999`	`}`
`1000`	`1000`
`1001`	`1001`	`const wasm::WasmObjectHeader &WasmObjectFile::getHeader() const {`