Skip to content

Commit f5e0b40

Browse files
author
Simon Dardis
committedFeb 21, 2018
[mips][lld] Address post commit review nit.
Address @RuiU's post commit review comment about a value which is intended to be a unsigned 32 bit integer as using uint32_t rather than unsigned. llvm-svn: 325713
1 parent 92f3578 commit f5e0b40

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed
 

‎lld/ELF/Arch/Mips.cpp

+2-3
Original file line numberDiff line numberDiff line change
@@ -331,9 +331,8 @@ void MIPS<ELFT>::writePlt(uint8_t *Buf, uint64_t GotPltEntryAddr,
331331
return;
332332
}
333333

334-
unsigned JrInst =
335-
isMipsR6() ? (Config->ZHazardplt ? 0x03200409 : 0x03200009)
336-
: (Config->ZHazardplt ? 0x03200408 : 0x03200008);
334+
uint32_t JrInst = isMipsR6() ? (Config->ZHazardplt ? 0x03200409 : 0x03200009)
335+
: (Config->ZHazardplt ? 0x03200408 : 0x03200008);
337336

338337
write32<E>(Buf, 0x3c0f0000); // lui $15, %hi(.got.plt entry)
339338
write32<E>(Buf + 4, 0x8df90000); // l[wd] $25, %lo(.got.plt entry)($15)

0 commit comments

Comments
 (0)
Please sign in to comment.