Skip to content

Commit 5489b9f

Browse files
committedJan 31, 2018
[WebAssembly] Reduce redundancy in tests
Add a simple start entry point input file and have the tests reference that rather than duplicating these. This allows more tests to be pure `.test` files rather than `.ll`. Differential Revision: https://reviews.llvm.org/D42662 llvm-svn: 323838
1 parent d3fad26 commit 5489b9f

File tree

6 files changed

+18
-26
lines changed

6 files changed

+18
-26
lines changed
 

‎lld/test/wasm/Inputs/start.ll

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
target triple = "wasm32-unknown-unknown-wasm"
2+
3+
define void @_start() local_unnamed_addr {
4+
entry:
5+
ret void
6+
}

‎lld/test/wasm/import-memory.test

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
# RUN: llc -filetype=obj %p/Inputs/ret32.ll -o %t.ret32.o
2-
# RUN: lld -flavor wasm -entry ret32 --import-memory -o %t.wasm %t.ret32.o
1+
# RUN: llc -filetype=obj %p/Inputs/start.ll -o %t.start.o
2+
# RUN: lld -flavor wasm --import-memory -o %t.wasm %t.start.o
33
# RUN: obj2yaml %t.wasm | FileCheck %s
44

55
# Verify the --import-memory flag creates a memory import

‎lld/test/wasm/invalid-stack-size.ll

-11
This file was deleted.

‎lld/test/wasm/invalid-stack-size.test

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
; RUN: llc -filetype=obj %p/Inputs/start.ll -o %t.o
2+
; RUN: not lld -flavor wasm -o %t.wasm -z stack-size=1 %t.o 2>&1 | FileCheck %s
3+
4+
; CHECK: error: stack size must be 16-byte aligned

‎lld/test/wasm/load-undefined.ll renamed to ‎lld/test/wasm/load-undefined.test

+4-11
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,11 @@
33
;
44
; RUN: llc -filetype=obj %S/Inputs/ret64.ll -o %t.o
55
; RUN: llc -filetype=obj %S/Inputs/ret32.ll -o %t2.o
6-
; RUN: llc -filetype=obj %s -o %t3.o
6+
; RUN: llc -filetype=obj %S/Inputs/start.ll -o %t.start.o
77
; RUN: llvm-ar rcs %t2.a %t2.o
8-
; RUN: lld -flavor wasm %t3.o %t2.a %t.o -o %t.wasm -u ret32 --undefined ret64
8+
; RUN: lld -flavor wasm %t.start.o %t2.a %t.o -o %t.wasm -u ret32 --undefined ret64
99
; RUN: obj2yaml %t.wasm | FileCheck %s
1010

11-
target triple = "wasm32-unknown-unknown-wasm"
12-
13-
define i32 @_start() local_unnamed_addr {
14-
entry:
15-
ret i32 1
16-
}
17-
1811
; CHECK: - Type: EXPORT
1912
; CHECK-NEXT: Exports:
2013
; CHECK-NEXT: - Name: memory
@@ -36,8 +29,8 @@ entry:
3629

3730

3831
; Verify that referencing a symbol that doesn't exist won't work
39-
; RUN: not lld -flavor wasm %t3.o -o %t.wasm -u symboldoesnotexist 2>&1 | FileCheck -check-prefix=CHECK-UNDEFINED1 %s
32+
; RUN: not lld -flavor wasm %t.start.o -o %t.wasm -u symboldoesnotexist 2>&1 | FileCheck -check-prefix=CHECK-UNDEFINED1 %s
4033
; CHECK-UNDEFINED1: error: undefined symbol: symboldoesnotexist
4134

42-
; RUN: not lld -flavor wasm %t3.o -o %t.wasm --undefined symboldoesnotexist --allow-undefined 2>&1 | FileCheck -check-prefix=CHECK-UNDEFINED2 %s
35+
; RUN: not lld -flavor wasm %t.start.o -o %t.wasm --undefined symboldoesnotexist --allow-undefined 2>&1 | FileCheck -check-prefix=CHECK-UNDEFINED2 %s
4336
; CHECK-UNDEFINED2: function forced with --undefined not found: symboldoesnotexist

‎lld/test/wasm/strip-debug.test

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
RUN: llc -filetype=obj %p/Inputs/ret32.ll -o %t.ret32.o
2-
RUN: lld -flavor wasm --strip-debug --entry=ret32 -o %t.wasm %t.ret32.o
1+
RUN: llc -filetype=obj %p/Inputs/start.ll -o %t.start.o
2+
RUN: lld -flavor wasm --strip-debug -o %t.wasm %t.start.o
33
RUN: obj2yaml %t.wasm | FileCheck %s
44

55
# Check that there is no name section

0 commit comments

Comments
 (0)
Please sign in to comment.