Skip to content

Commit 7cd7c1a

Browse files
committedJul 10, 2017
[tsan] Add comments for the bool argument of ThreadIgnoreBegin/ThreadIgnoreSyncBegin, NFC.
Differential Revision: https://reviews.llvm.org/D35134 llvm-svn: 307545
1 parent f20cb69 commit 7cd7c1a

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed
 

‎compiler-rt/lib/tsan/rtl/tsan_interceptors.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ ScopedInterceptor::~ScopedInterceptor() {
261261

262262
void ScopedInterceptor::EnableIgnores() {
263263
if (ignoring_) {
264-
ThreadIgnoreBegin(thr_, pc_, false);
264+
ThreadIgnoreBegin(thr_, pc_, /*save_stack=*/false);
265265
if (flags()->ignore_noninstrumented_modules) thr_->suppress_reports++;
266266
if (in_ignored_lib_) {
267267
DCHECK(!thr_->in_ignored_lib);

‎compiler-rt/lib/tsan/rtl/tsan_interface_ann.cc

+8-8
Original file line numberDiff line numberDiff line change
@@ -483,8 +483,8 @@ void __tsan_mutex_pre_lock(void *m, unsigned flagz) {
483483
else
484484
MutexPreLock(thr, pc, (uptr)m);
485485
}
486-
ThreadIgnoreBegin(thr, pc, false);
487-
ThreadIgnoreSyncBegin(thr, pc, false);
486+
ThreadIgnoreBegin(thr, pc, /*save_stack=*/false);
487+
ThreadIgnoreSyncBegin(thr, pc, /*save_stack=*/false);
488488
}
489489

490490
INTERFACE_ATTRIBUTE
@@ -510,8 +510,8 @@ int __tsan_mutex_pre_unlock(void *m, unsigned flagz) {
510510
} else {
511511
ret = MutexUnlock(thr, pc, (uptr)m, flagz);
512512
}
513-
ThreadIgnoreBegin(thr, pc, false);
514-
ThreadIgnoreSyncBegin(thr, pc, false);
513+
ThreadIgnoreBegin(thr, pc, /*save_stack=*/false);
514+
ThreadIgnoreSyncBegin(thr, pc, /*save_stack=*/false);
515515
return ret;
516516
}
517517

@@ -525,8 +525,8 @@ void __tsan_mutex_post_unlock(void *m, unsigned flagz) {
525525
INTERFACE_ATTRIBUTE
526526
void __tsan_mutex_pre_signal(void *addr, unsigned flagz) {
527527
SCOPED_ANNOTATION(__tsan_mutex_pre_signal);
528-
ThreadIgnoreBegin(thr, pc, false);
529-
ThreadIgnoreSyncBegin(thr, pc, false);
528+
ThreadIgnoreBegin(thr, pc, /*save_stack=*/false);
529+
ThreadIgnoreSyncBegin(thr, pc, /*save_stack=*/false);
530530
}
531531

532532
INTERFACE_ATTRIBUTE
@@ -547,7 +547,7 @@ void __tsan_mutex_pre_divert(void *addr, unsigned flagz) {
547547
INTERFACE_ATTRIBUTE
548548
void __tsan_mutex_post_divert(void *addr, unsigned flagz) {
549549
SCOPED_ANNOTATION(__tsan_mutex_post_divert);
550-
ThreadIgnoreBegin(thr, pc, false);
551-
ThreadIgnoreSyncBegin(thr, pc, false);
550+
ThreadIgnoreBegin(thr, pc, /*save_stack=*/false);
551+
ThreadIgnoreSyncBegin(thr, pc, /*save_stack=*/false);
552552
}
553553
} // extern "C"

0 commit comments

Comments
 (0)